Add java gc exporter to exporter list#2387
Add java gc exporter to exporter list#2387juliusv merged 2 commits intoprometheus:mainfrom loyispa:java-gc-exporter
Conversation
Signed-off-by: loyispa <litiegen456250@gmail.com>
|
Thanks! CC-ing @fstab here just for a quick glance because I know nothing about Java, and he can judge the metrics and possible overlap with any of the other Java exporters better :) Some notes from my side: Please keep the list lexicographically sorted:
And if we link it here, we'll want to make sure that the exporter somewhat sticks to the general and exporter-specific metrics naming guidelines, see https://prometheus.io/docs/practices/naming/ and https://prometheus.io/docs/instrumenting/writing_exporters/#metrics. Specifically:
|
Signed-off-by: loyispa <litiegen456250@gmail.com>
Thanks for your explaination, i will make an update next. |
|
Hi @juliusv, dou you have time to review the changes? I have renamed the metrics as per the guidelines, thanks. Sample metrics: |
|
👍 Thanks for the updates! Yeah that looks much better at a glance. I don't know anything about Java, but should be good to merge at least :) |
|
Thanks for the new exporter @loyispa. This parses GC log files, right? I guess in that case it makes sense to have it as an independent exporter, because parsing GC log files doesn't really fit with |
|
@fstab Yes, It parses the raw gc log as an independent exporter. Thanks for the advice, I will consider how to implement it appropriately with client_java :) |
Please add this new exporter to exporter list. Please let me know if something missing, thanks.
Sample metrics: