remote-write: Add hint to check for CPU and network saturation#2484
Merged
remote-write: Add hint to check for CPU and network saturation#2484
Conversation
This is very general advice, but we don't have a rule of thumb available right now (plus, PRW 2.0 will change a lot here anyway). This "fixes" #8890. Signed-off-by: beorn7 <beorn@grafana.com>
krajorama
approved these changes
Jun 25, 2024
Member
krajorama
left a comment
There was a problem hiding this comment.
ideally we include what metrics to look at for rw lag, but this is already an improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very general advice, but we don't have a rule of thumb available right now (plus, PRW 2.0 will change a lot here anyway).
This "fixes" #8890.
@bboreham @krajorama as discussed.