feat: add mentorship section with some tips for mentees and mentors#2717
Merged
feat: add mentorship section with some tips for mentees and mentors#2717
Conversation
Member
Author
|
Building is failing on main too, investingating. |
saswatamcode
approved these changes
Sep 4, 2025
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Thanks! LGTM! 💪🏻
Few small nits
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
saswatamcode
approved these changes
Sep 4, 2025
juliusv
reviewed
Sep 4, 2025
Member
juliusv
left a comment
juliusv
left a comment
There was a problem hiding this comment.
A bunch of small grammar/typo/style nits, but overall it looks like good content.
Co-authored-by: Julius Volz <julius.volz@gmail.com> Co-authored-by: Victoria Nduka <122698422+nwanduka@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Member
Author
|
Thanks for epic review, addressed! |
ArthurSens
approved these changes
Sep 6, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of this is ported from Thanos docs we made long time ago: https://thanos.io/tip/contributing/mentorship.md/ -- updated for Prometheus and 2025.