feat(om1.1): relax the requirements around unit and total suffixes#2750
Merged
feat(om1.1): relax the requirements around unit and total suffixes#2750
Conversation
Allow exposers to expose metrics that do not put `_total` or unit as suffix to metric names. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dashpole
reviewed
Oct 3, 2025
Co-authored-by: David Ashpole <dashpole@google.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
dashpole
reviewed
Oct 3, 2025
dashpole
approved these changes
Oct 3, 2025
Member
|
PR description needs to be updated |
ywwg
reviewed
Oct 3, 2025
| ##### Counter | ||
|
|
||
| The MetricPoint's Total Value Sample MetricName MUST have the suffix `_total`. If present the MetricPoint's Created Value Sample MetricName MUST have the suffix `_created`. | ||
| The MetricPoint's Total Value Sample MetricName SHOULD have the suffix `_total`. If present the MetricPoint's Created Value Sample MetricName MUST have the suffix `_created`. |
Member
There was a problem hiding this comment.
hmmm, I'm not sure how Otel deals with created metrics. I am tempted not to have any MUSTs around names so that we can truly allow anything and not be against the spec (no matter how much we discourage it)
Contributor
There was a problem hiding this comment.
I think we need a MUST for the _created series, otherwise it wouldn't be the _created series :).
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
ywwg
approved these changes
Oct 6, 2025
This was referenced Oct 8, 2025
krajorama
added a commit
that referenced
this pull request
Oct 30, 2025
Fixes: prometheus/OpenMetrics#286 Based on #2750 and #2751 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added a commit
that referenced
this pull request
Oct 31, 2025
Fixes: prometheus/OpenMetrics#286 Based on #2750 and #2751 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow exposers to expose metrics that do not put
_totalor unit as suffix to metric names.Out of scope: note that this does not relax rules around the uniqueness of metric family names!
Alternatives considered:
openmetrics-permissive-textand only relax rules if content negotiation yieldspermissive.openmetrics-strict-textand only relax rules if content negotiation is notstrict.Related to prometheus/OpenMetrics#286