Fix typo with broken link the instrumenting documentation#2753
Merged
juliusv merged 1 commit intoprometheus:mainfrom Oct 30, 2025
Merged
Fix typo with broken link the instrumenting documentation#2753juliusv merged 1 commit intoprometheus:mainfrom
juliusv merged 1 commit intoprometheus:mainfrom
Conversation
Member
|
Thanks! Hmm, I think the link to the GitHub repo file is better here, since the sentence asks the reader to send a PR to change that file, and they need to know where it lives to do that. If you like, you could reword the sentence to mention both the page URL and its source though. |
Signed-off-by: pako-23 <pasqualepolverino98@gmail.com>
Contributor
Author
|
Hi @juliusv, I made some rewarding as you suggested. I hope it helps, but if you think the old version is more clear feel free to close this PR |
Member
|
@pako-23 Thanks, I like it :) 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Writing exporters documentation has a broken link in the Announcing section. Assuming it points to Exporters and integrations.
FYI: @juliusv