content: clarifications around adding a new team member in governance #991
Conversation
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
Generally in favor of more detail. Thanks for taking action on this!
content/governance.md
Outdated
| New members may be proposed by any existing member by email to [prometheus-team][team]. It is highly desirable to reach consensus about acceptance of a new member. However, the proposal is ultimately voted on by a formal [supermajority vote](#supermajority-vote). | ||
|
|
||
| Team members are added to the [GitHub organization][gh] as _Owner_. They should however respect the maintainers of each project. | ||
| If the new member proposal is accepted, the proposed team member should be contacted privately to confirm or deny their acceptance of team membership. If they choose to accept, the following steps should be taken: |
There was a problem hiding this comment.
"If they choose to accept, the following steps are taken:"
There was a problem hiding this comment.
I would contact them CC'ed to the team list. Abuse is very unlikely here, but there should be a paper trail on this.
content/governance.md
Outdated
| Team members are added to the [GitHub organization][gh] as _Owner_. They should however respect the maintainers of each project. | ||
| If the new member proposal is accepted, the proposed team member should be contacted privately to confirm or deny their acceptance of team membership. If they choose to accept, the following steps should be taken: | ||
|
|
||
| * Team members are added to the [GitHub organization][gh] as _Owner_. They should however respect the maintainers of each project. |
There was a problem hiding this comment.
The second description is a definition of team member vs. maintainer. Not necessary to re-iterate here I think.
There was a problem hiding this comment.
I have no qualms removing this; I just copied the existing sentence from line 35.
|
👍 from me |
content/governance.md
Outdated
| New members may be proposed by any existing member by email to [prometheus-team][team]. It is highly desirable to reach consensus about acceptance of a new member. However, the proposal is ultimately voted on by a formal [supermajority vote](#supermajority-vote). | ||
|
|
||
| Team members are added to the [GitHub organization][gh] as _Owner_. They should however respect the maintainers of each project. | ||
| If the new member proposal is accepted, the proposed team member should be contacted privately to confirm or deny their acceptance of team membership. If they choose to accept, the following steps should be taken: |
There was a problem hiding this comment.
I would contact them CC'ed to the team list. Abuse is very unlikely here, but there should be a paper trail on this.
|
We should also add team members to the lastpass password store. |
|
PS: Once this PR is ready, we will need to vote on it on the list again. |
I don't think we should get to that level of detail in this document, I don't think it's sane to need a vote for every new type of access we have. |
|
Valid point, but then the logical conclusion is that any list is bound to be incomplete and thus misleading. |
|
I'm not saying we shouldn't have a list, I'm saying that the list doesn't belong in this document. |
|
I've added a new commit that I believe accounts for all feedback given thus far. My plan is to put this to a vote on Friday in a new thread on prometheus-developers. In the mean time, please keep non-wording/spelling/grammar discussion on the mailing list thread, thanks! |
|
lgtm |
content/governance.md
Outdated
| New members may be proposed by any existing member by email to [prometheus-team][team]. It is highly desirable to reach consensus about acceptance of a new member. However, the proposal is ultimately voted on by a formal [supermajority vote](#supermajority-vote). | ||
|
|
||
| If the new member proposal is accepted, the proposed team member should be contacted privately to confirm or deny their acceptance of team membership. If they choose to accept, the following steps should be taken: | ||
| If the new member proposal is accepted, the proposed team member should be contacted privately via email to confirm or deny their acceptance of team membership. This email should also be CC'd to [prometheus-team][team] for record keeping purposes. |
|
Added a final nitpick. We should freeze this PR and then toss it onto the ML. |
|
All done. Starting a vote thread now. |
|
|
||
| * Team members are added to the list of team members in this document. | ||
|
|
||
| * New team members are announced on the [developers mailing list][devs] by an existing team member. |
There was a problem hiding this comment.
Formatting nit: Blank lines between list items create <p>-wrapped items. It looks a bit weird as the next list in this section does not have blank lines between list items. (However, the list at the top has it, perhaps deliberately so.)
There was a problem hiding this comment.
I believe that the markdown linting tool I have installed in VSCode recommended this formatting.
I don't feel strongly either way, but it is odd that we already have both styles in place.
content/governance.md
Outdated
| New members may be proposed by any existing member by email to [prometheus-team][team]. It is highly desirable to reach consensus about acceptance of a new member. However, the proposal is ultimately voted on by a formal [supermajority vote](#supermajority-vote). | ||
|
|
||
| Team members are added to the [GitHub organization][gh] as _Owner_. They should however respect the maintainers of each project. | ||
| If the new member proposal is accepted, the proposed team member should be contacted privately via email to confirm or deny their acceptance of team membership. This email will also be CC'd to [prometheus-team][team] for record keeping purposes. |
|
The vote for these changes has passed with 15 affirmative votes! Will wait for a final PR approval from a member of the team, then merge. |
|
As per the vote: LGTM
Sent by mobile; please excuse my brevity.
…On Mon, Mar 26, 2018, 17:09 Matt Layher ***@***.***> wrote:
The vote for these changes has passed with 15 affirmative votes! Will wait
for a final PR approval from a member of the team, then merge.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#991 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAuEI_FZRaRbc3gQk2i6-B4IPkSAwXy1ks5tiQS1gaJpZM4SuCgV>
.
|
juliusv
dismissed
RichiH’s stale review
Comments are addressed, LGTM via email.
6 participants
I propose these changes to our governance process to clarify some of the steps taken when adding Krasi as a new member of the Prometheus team.
@juliusv mentioned this in an email in the group:
It feels like it's worth explicitly stating this. I have also added a couple bullets so that team members have a checklist for adding new members.
I'll create a thread on developers regarding these changes, so that we can gather feedback and comments on the wording, process, etc.
If the response is favorable, I will call a formal vote on the list at a later time.
Please only comment on GitHub for minor changes such as wording, grammer, etc. In depth discussion should take place on the developers thread here, per our governance: https://groups.google.com/forum/#!topic/prometheus-developers/qr9rbdZUsnY.