feat(om2): exemplar timestamp MAY to SHOULD #2775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the exemplar timestamp a SHOULD in preparation for complex types having multiple exemplars at a time. We'll explain why having timestamp for exemplars of complex types is a good idea there. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the exemplar timestamp a SHOULD in preparation for complex types having multiple exemplars at a time.
Note: the current Prometheus implementation can deal with one exemplar per time series without timestamp. Because at scrape if the exemplar doesn't have a timestamp than Prometheus will compare the exemplar's value to the last exemplar for the series. If the value and labels are the same, the exemplar is dropped. This strategy doesn't work for complex types as they get multiple exemplars and the current implementation cannot go back and figure out how many exemplars were in the last scrape.