-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Gearman exporter #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gearman exporter #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you unregistering the processes and Go collectors? You still want to monitor the exporter itself.
Version information should not be added as a label on gearman_up, that'd be quite annoying to deal with. Put the label on a separate metric.
gearman_status_total is a gauge, and should thus not end in _total. Something like gearman_jobs_queued would be a better name.
| * [MQTT blackbox exporter](https://github.com/inovex/mqtt_blackbox_exporter) | ||
| * [RabbitMQ exporter](https://github.com/kbudde/rabbitmq_exporter) | ||
| * [RabbitMQ Management Plugin exporter](https://github.com/deadtrickster/prometheus_rabbitmq_exporter) | ||
| * [Gearman exporter](https://github.com/bakins/gearman-exporter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it sorted.
|
Thanks for the feedback! I will fix it and then get back to you. |
|
@brian-brazil wdyt? |
Might be useful for someone. Via prometheus/docs#980 (review)
Everything in metrics is some form of total, it rarely adds anything to a metric name. _jobs and _jobs_running would be the usual way to organise that. |
|
@brian-brazil I went with your suggestion. Could you take another look? |
|
You still have the version label on |
|
I split it into two metrics, as you recommend in your blogpost: Did I miss some place to update it? |
|
Odd, it was missing when I had last looked. |
@brian-brazil ping