Skip to content

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Feb 6, 2025

  • Bump Goreleaser to v2.6.1.
  • Bump YQ to v4.45.1.
  • Bump gotestsum to v1.12.0.
  • Bump Node to 22.
  • Fixup Node download.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 6, 2025

@Nexucis I figured out the new URL locations for node 22.

@SuperQ SuperQ requested a review from Nexucis February 6, 2025 15:07
@Nexucis Nexucis mentioned this pull request Feb 6, 2025
@Nexucis
Copy link
Member

Nexucis commented Feb 6, 2025

nice @SuperQ !

CI is failing but that's for others reason than nodeJS not found

* Bump Goreleaser to v2.6.1.
* Bump YQ to v4.45.1.
* Bump gotestsum to v1.12.0.
* Bump Node to 22.
* Fixup Node download.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Member Author

SuperQ commented Feb 6, 2025

CC @jan--f. I feel like we should hold off on this until 3.2.x is done and we're ready for 3.3.x. Unless you want to do this now as part of 3.2.0.

@SuperQ SuperQ marked this pull request as draft February 6, 2025 20:42
@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2025

Thanks!

NOTE: Without this we cannot use prombench (easily) to test 3.2.0 to 3.1.0 or past so I highly recommend including this in 3.2.0

@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2025

Alternatively we can create a tmp image to use for now to unblock prometheus/test-infra#832 from this PR, not a bad solution. Will try to do that.

@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2025

FYI: Last step fails for 1.23.6-main, doing some other work, then will investigate.

>> building quay.io/prometheus/golang-builder:1.23.6-main-superq-node22
...
Removing intermediate container 64fe22b9b886
 ---> d52fff8e0abd
Step 6/13 : COPY --from=rustbuilder /usr/local/cargo/bin/rcodesign /usr/local/bin/rcodesign
 ---> 77963e07205f
Step 7/13 : ARG PROM_OSX_SDK_URL
 ---> Running in a0e65d618226
Removing intermediate container a0e65d618226
 ---> b31ba8952e02
Step 8/13 : ENV OSXCROSS_PATH=/usr/osxcross     OSXCROSS_REV=ff8d100f3f026b4ffbe4ce96d8aac4ce06f1278b     SDK_VERSION=14     DARWIN_VERSION=23     OSX_VERSION_MIN=10.13
 ---> Running in 5caad906d616
Removing intermediate container 5caad906d616
 ---> dffb5621796f
Step 9/13 : WORKDIR /tmp/osxcross
 ---> Running in ea58c941f690
Removing intermediate container ea58c941f690
 ---> 5a10b4638633
Step 10/13 : RUN     curl -s -f -L "https://codeload.github.com/tpoechtrager/osxcross/tar.gz/${OSXCROSS_REV}"       | tar -C /tmp/osxcross --strip=1 -xzf -     && curl -s -f -L "${PROM_OSX_SDK_URL}/MacOSX${SDK_VERSION}.sdk.tar.xz" -o "tarballs/MacOSX${SDK_VERSION}.sdk.tar.xz"     && UNATTENDED=yes JOBS=2 ./build.sh     && mv target "${OSXCROSS_PATH}"     && rm -rf /tmp/osxcross "/usr/osxcross/SDK/MacOSX${SDK_VERSION}.sdk/usr/share/man"
 ---> Running in 08455e16cd81
The command '/bin/sh -c curl -s -f -L "https://codeload.github.com/tpoechtrager/osxcross/tar.gz/${OSXCROSS_REV}"       | tar -C /tmp/osxcross --strip=1 -xzf -     && curl -s -f -L "${PROM_OSX_SDK_URL}/MacOSX${SDK_VERSION}.sdk.tar.xz" -o "tarballs/MacOSX${SDK_VERSION}.sdk.tar.xz"     && UNATTENDED=yes JOBS=2 ./build.sh     && mv target "${OSXCROSS_PATH}"     && rm -rf /tmp/osxcross "/usr/osxcross/SDK/MacOSX${SDK_VERSION}.sdk/usr/share/man"' returned a non-zero code: 3
make[1]: *** [Makefile:18: build] Error 3
make[1]: Leaving directory '/usr/local/google/home/bwplotka/Repos/golang-builder/1.23/main'
make: *** [Makefile:22: build] Error 2

bwplotka added a commit to prometheus/test-infra that referenced this pull request Feb 7, 2025
…ch runs

This custom image is locally build from prometheus/golang-builder#296
that we agree to pause until Prometheus release. However, Prometheus release
needs working prombench. This is a tmp solution until we have an official image.

Mitigates #832

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2025

But fails happens on main image, I think we should be good just with base. Testing prometheus/test-infra#833

@SuperQ SuperQ requested a review from jan--f February 7, 2025 09:55
bwplotka added a commit to prometheus/test-infra that referenced this pull request Feb 7, 2025
…ch runs (#833)

This custom image is locally build from prometheus/golang-builder#296
that we agree to pause until Prometheus release. However, Prometheus release
needs working prombench. This is a tmp solution until we have an official image.

Mitigates #832

Signed-off-by: bwplotka <bwplotka@gmail.com>
kushalShukla-web pushed a commit to kushalShukla-web/test-infra that referenced this pull request Feb 8, 2025
…ch runs (prometheus#833)

This custom image is locally build from prometheus/golang-builder#296
that we agree to pause until Prometheus release. However, Prometheus release
needs working prombench. This is a tmp solution until we have an official image.

Mitigates prometheus#832

Signed-off-by: bwplotka <bwplotka@gmail.com>
@SuperQ SuperQ mentioned this pull request Feb 20, 2025
@SuperQ SuperQ marked this pull request as ready for review March 5, 2025 14:46
@SuperQ
Copy link
Member Author

SuperQ commented Mar 5, 2025

@machine424 I'm going to merge this so we can do the 1.24.x upgrade.

@SuperQ SuperQ merged commit 785836c into master Mar 5, 2025
4 checks passed
@SuperQ SuperQ deleted the superq/node22 branch March 5, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants