This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Document passing arguments through a file#248
Merged
matthiasr merged 1 commit intoprometheus:mainfrom Feb 14, 2023
Merged
Conversation
Providing basic auth parameters through the command line is insecure and raised some eyebrows in prometheus#102 Kingpin in https://github.com/alecthomas/kingpin#reading-arguments-from-a-file provides a way to specify parameters through a file so we can document that too. In addition to prevent the leak of the password in the process table (making any user currently logged on the machine able to read the password), this also prevent a remote user to read the credentials through the pprof cmdline service. Signed-off-by: François Rigault <frigo@amadeus.com>
freedge
force-pushed
the
passwordInFile
branch
from
9ca1a0a to
43abd70
Compare
Contributor
|
Thank you, Today I Learned 😄 |
Member
|
We should add this documentation to all the repos that support kingpin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing basic auth parameters through the command line
is insecure and raised some eyebrows in
#102
Kingpin in
https://github.com/alecthomas/kingpin#reading-arguments-from-a-file
provides a way to specify parameters through a file so we can
document that too.
In addition to prevent the leak of the password in the process table
(making any user currently logged on the machine able to read the
password), this also prevent a remote user to read the credentials
through the pprof cmdline service.
Signed-off-by: François Rigault frigo@amadeus.com