Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

Add current_queue metric for servers#44

Merged
discordianfish merged 1 commit intomasterfrom
fish/add-frontend-and-server-queue
Mar 30, 2016
Merged

Add current_queue metric for servers#44
discordianfish merged 1 commit intomasterfrom
fish/add-frontend-and-server-queue

Conversation

@discordianfish
Copy link
Copy Markdown
Member

Test it here and looks good.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not queueing servers but requests. Maybe let's improve this and the backend's help message. First idea:

server: Current number of queued requests assigned to this server.
backend: Current number of queued requests not assigned to any server.

@grobie
Copy link
Copy Markdown
Member

grobie commented Mar 29, 2016

👍 after improving the help messages.

@discordianfish discordianfish force-pushed the fish/add-frontend-and-server-queue branch 2 times, most recently from 631778b to 5739718 Compare March 29, 2016 17:55
@discordianfish
Copy link
Copy Markdown
Member Author

@grobie I've changed the description but are we sure that it's correct? I would have assumed that backend queue is the sum of all servers queue, no the spillover where it can't assign requests to any servers anymore..?

@discordianfish
Copy link
Copy Markdown
Member Author

Reading the haproxy docs I guess you're right, although I'm not completely sure..
If you are, feel free to merge this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's adjust the max queue help as well for consistency.

@grobie
Copy link
Copy Markdown
Member

grobie commented Mar 29, 2016

I haven't come across a HAProxy setup which is configured to queue in a while. At SoundCloud none of our servers have a configured maxconn, therefore HAProxy will never queue any requests.

I can't tell you when it's possible that a request is queued on a server, and not the global queue. In our old mothership routing stacks I believe only the global queue was used.

@discordianfish discordianfish force-pushed the fish/add-frontend-and-server-queue branch from 5739718 to 87c14c4 Compare March 30, 2016 09:29
@discordianfish discordianfish merged commit 7f12f80 into master Mar 30, 2016
@discordianfish discordianfish deleted the fish/add-frontend-and-server-queue branch March 30, 2016 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants