-
Notifications
You must be signed in to change notification settings - Fork 803
Added docker file #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That Dockerfile requires the binary to exist already, so it can't be used with automated builds. @mlety2 Do you want to change the Dockerfile to use alpine linux and install + cleanup stuff in one RUN command like we do here? https://github.com/prometheus/prometheus/blob/master/Dockerfile |
|
Ok sure. I originally had a script that would build the binary in a debian container. Would that play well with automated builds? |
|
@mlety2 Unfortunately not, the automated build service will basically just checkout the repo and run 'docker build', so everything needs to happen in the Dockerfile. |
|
I added the build steps to the debian image. I couldn't get the make script to recognise go installed via the alpine package manager. I also couldn't get the go binary from https://golang.org/dl to run in alpine either, I kept getting |
|
Okay, I think this is good for now. Thanks! @juliusv LGTM |
|
@juliusv Can you add the docker webhook? Or give me permissions to do so. Or add the docker automated builds yourself :) |
|
@discordianfish Added the "Docker" Service for now. |
|
FYI: The image is added to our docker hub account: https://registry.hub.docker.com/u/prom/mysqld-exporter/ |
# This is the 1st commit message: Move session params to DSN (prometheus#259) * Move session params to DSN In order to avoid lost session params if the `db` object reconnects in the background, move session params to the DSN string configuration. * Move log_slow_filter flag to exporter * Update flag name to be in `exporter` namespace. * Update README. * Tweak exporter.log_slow_filter flag documentation. # This is the commit message prometheus#2: Fix lock_wait_timeout after prometheus#259 (prometheus#263) # This is the commit message prometheus#3: Broken landing page, doesn't include metric path. (prometheus#264) * Broken landing page, doesn't include metric path. * Fix landing page. # This is the commit message prometheus#4: first commit Signed-off-by: Roi Ezra <ezraroi@gmail.com> # This is the commit message prometheus#5: fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com> # This is the commit message prometheus#6: fixed code review Signed-off-by: Roi Ezra <ezraroi@gmail.com>
PMM-1011: Merge upstream changes
No description provided.