Skip to content

Conversation

@matthewrj
Copy link

No description provided.

@juliusv
Copy link
Member

juliusv commented Apr 30, 2015

@discordianfish

@discordianfish
Copy link
Member

That Dockerfile requires the binary to exist already, so it can't be used with automated builds.
I'm not opposed to use binaries built outside Docker in general because that might reduce image size and we can reuse the same build process but until we have a process to build and distribute binaries, I would make the Dockerfiles build the binaries on their own.

@mlety2 Do you want to change the Dockerfile to use alpine linux and install + cleanup stuff in one RUN command like we do here? https://github.com/prometheus/prometheus/blob/master/Dockerfile

@matthewrj
Copy link
Author

Ok sure. I originally had a script that would build the binary in a debian container. Would that play well with automated builds?

@discordianfish
Copy link
Member

@mlety2 Unfortunately not, the automated build service will basically just checkout the repo and run 'docker build', so everything needs to happen in the Dockerfile.

@matthewrj
Copy link
Author

I added the build steps to the debian image. I couldn't get the make script to recognise go installed via the alpine package manager. I also couldn't get the go binary from https://golang.org/dl to run in alpine either, I kept getting /bin/sh: /src/.build/go1.4.2/bin/go: not found even though it was definitely there.

@discordianfish
Copy link
Member

Okay, I think this is good for now. Thanks! @juliusv LGTM

juliusv added a commit that referenced this pull request May 11, 2015
@juliusv juliusv merged commit 8424d4e into prometheus:master May 11, 2015
@discordianfish
Copy link
Member

@juliusv Can you add the docker webhook? Or give me permissions to do so. Or add the docker automated builds yourself :)

@juliusv
Copy link
Member

juliusv commented May 11, 2015

@discordianfish Added the "Docker" Service for now.

@discordianfish
Copy link
Member

FYI: The image is added to our docker hub account: https://registry.hub.docker.com/u/prom/mysqld-exporter/

ezraroi pushed a commit to ezraroi/mysqld_exporter that referenced this pull request Apr 17, 2018
# This is the 1st commit message:

Move session params to DSN (prometheus#259)

* Move session params to DSN

In order to avoid lost session params if the `db` object reconnects in
the background, move session params to the DSN string configuration.

* Move log_slow_filter flag to exporter

* Update flag name to be in `exporter` namespace.
* Update README.

* Tweak exporter.log_slow_filter flag documentation.

# This is the commit message prometheus#2:

Fix lock_wait_timeout after prometheus#259 (prometheus#263)


# This is the commit message prometheus#3:

Broken landing page, doesn't include metric path. (prometheus#264)

* Broken landing page, doesn't include metric path.

* Fix landing page.

# This is the commit message prometheus#4:

first commit

Signed-off-by: Roi Ezra <ezraroi@gmail.com>

# This is the commit message prometheus#5:

fixed code review

Signed-off-by: Roi Ezra <ezraroi@gmail.com>

# This is the commit message prometheus#6:

fixed code review

Signed-off-by: Roi Ezra <ezraroi@gmail.com>
arvenil added a commit to arvenil/mysqld_exporter that referenced this pull request Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants