Filter out uninstalled systemd units when collecting all units#1011
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Jul 22, 2018
xginn8:fix_567
Merged
Filter out uninstalled systemd units when collecting all units#1011SuperQ merged 1 commit intoprometheus:masterfrom xginn8:fix_567
SuperQ merged 1 commit intoprometheus:masterfrom
xginn8:fix_567
Conversation
SuperQ
reviewed
Jul 19, 2018
CHANGELOG.md
Outdated
Member
There was a problem hiding this comment.
Minor nit, this should be #1011 to reference the PR, not the issue.
Contributor
Author
|
gah, sorry about that! fixed in the most recent push. |
SuperQ
reviewed
Jul 19, 2018
collector/systemd_linux.go
Outdated
Member
There was a problem hiding this comment.
Please make comments full sentences, start with capitol and end with a ..
Contributor
Author
|
fixed up the comment, @SuperQ PTAL |
Member
|
It looks like the CircleCI outage caused the build request to get lost. I guess you could push a commit and then roll it back to trigger a rebuild. |
fixes #567 Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
Contributor
Author
|
@SuperQ builds are passing again, thanks for the heads up! |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…theus#1011) fixes prometheus#567 Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #567
Signed-off-by: xginn8 mamcgi@gmail.com