Skip to content

Conversation

@pgier
Copy link
Contributor

@pgier pgier commented Oct 24, 2018

… them

Signed-off-by: Paul Gier pgier@redhat.com

… them

Signed-off-by: Paul Gier <pgier@redhat.com>
@pgier
Copy link
Contributor Author

pgier commented Oct 24, 2018

See #1109
@bobrik please take a look

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bobrik bobrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Paul Gier <pgier@redhat.com>
@SuperQ SuperQ merged commit 38163f2 into prometheus:master Oct 30, 2018
iori-yja pushed a commit to iori-yja/node_exporter that referenced this pull request Nov 2, 2018
prometheus#1125)

* collector/diskstats: don't fail if there are extra stats, just ignore them

Signed-off-by: Paul Gier <pgier@redhat.com>
Signed-off-by: iori-yja <fivio.11235813@gmail.com>
SuperQ pushed a commit that referenced this pull request Nov 30, 2018
#1125)

* collector/diskstats: don't fail if there are extra stats, just ignore them

Signed-off-by: Paul Gier <pgier@redhat.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ pushed a commit that referenced this pull request Nov 30, 2018
#1125)

* collector/diskstats: don't fail if there are extra stats, just ignore them

Signed-off-by: Paul Gier <pgier@redhat.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
prometheus#1125)

* collector/diskstats: don't fail if there are extra stats, just ignore them

Signed-off-by: Paul Gier <pgier@redhat.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
prometheus#1125)

* collector/diskstats: don't fail if there are extra stats, just ignore them

Signed-off-by: Paul Gier <pgier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants