Skip to content

collector: add bounds check and test for filesystem collector#1133

Merged
SuperQ merged 1 commit intomasterfrom
mdl-filesystem-bounds
Oct 30, 2018
Merged

collector: add bounds check and test for filesystem collector#1133
SuperQ merged 1 commit intomasterfrom
mdl-filesystem-bounds

Conversation

@mdlayher
Copy link
Contributor

Signed-off-by: Matt Layher mdlayher@gmail.com

Previously, this code could panic and take down node_exporter if the info was malformed.

Signed-off-by: Matt Layher <mdlayher@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great!

@SuperQ SuperQ merged commit c0a55e3 into master Oct 30, 2018
@SuperQ SuperQ deleted the mdl-filesystem-bounds branch October 30, 2018 21:12
iori-yja pushed a commit to iori-yja/node_exporter that referenced this pull request Nov 2, 2018
…heus#1133)

Signed-off-by: Matt Layher <mdlayher@gmail.com>
Signed-off-by: iori-yja <fivio.11235813@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants