Change Dfly's CPU counting frequency#1140
Merged
SuperQ merged 2 commits intoprometheus:masterfrom Nov 21, 2018
Merged
Conversation
iori-yja
changed the title
Member
|
@stuartnelson3 Could you confirm whether this still works on your system? In that case I'd merge this. |
discordianfish
approved these changes
Nov 5, 2018
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
LGTM, pending @stuartnelson3 confirmation.
Contributor
😅 I would but that machine has been turned into a linux machine |
Signed-off-by: iori-yja <fivo.11235813@gmail.com>
Signed-off-by: iori-yja <fivo.11235813@gmail.com>
iori-yja
force-pushed
the
fix-cpu-counterfreq-dfly
branch
from
216fedb to
460e845
Compare
Contributor
Author
|
fixed for DCO check |
Member
|
@SuperQ ping |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have confirmed this simple unit change works fine with following step:
cat /dev/urandom | gzip -c > /dev/nullas many as the number of cores (it was 4 here)(sum(irate(node_cpu_seconds_total{}[5m])) - sum(irate(node_cpu_seconds_total{mode="idle"}[5m])))reports similar number as above (was completely same to 4 in grafana dashborad)Fixes: #1129