Remove unused variable readOnly from filesystem_linux.go#1173
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Nov 30, 2018
jeromefroe:jeromefroe/remove-unused-variable
Merged
Remove unused variable readOnly from filesystem_linux.go#1173SuperQ merged 1 commit intoprometheus:masterfrom jeromefroe:jeromefroe/remove-unused-variable
SuperQ merged 1 commit intoprometheus:masterfrom
jeromefroe:jeromefroe/remove-unused-variable
Conversation
The pull request #1002 changed the logic used on Linux servers to determine if a filesystem is read-only. As a result of this change, the variable `readOnly` is now unused and can be removed. Signed-off-by: Jerome Froelich <jeromefroelich@hotmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…#1173) The pull request prometheus#1002 changed the logic used on Linux servers to determine if a filesystem is read-only. As a result of this change, the variable `readOnly` is now unused and can be removed. Signed-off-by: Jerome Froelich <jeromefroelich@hotmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…#1173) The pull request prometheus#1002 changed the logic used on Linux servers to determine if a filesystem is read-only. As a result of this change, the variable `readOnly` is now unused and can be removed. Signed-off-by: Jerome Froelich <jeromefroelich@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request #1002 changed the logic used on Linux servers to determine if a filesystem is
read-only. As a result of this change, the variable
readOnlyis now unused and can be removed.Signed-off-by: Jerome Froelich jeromefroelich@hotmail.com