Make filesystem collector more robust. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behaviour throws away all stats on any Statfs error. In practice this is not useful. This turns such errors into debug log messages - though silently ignoring them seems even more valid to me.
Contributor
|
Considering the various ways we've seen this fail, I think this is the most pragmatic solution. 👍 |
Contributor
Author
|
Do I need to do anything to get this merged? |
Contributor
|
No, thanks and sorry about the delay 👍 |
fabxc
added a commit
that referenced
this pull request
Oct 20, 2015
Make filesystem collector more robust.
Contributor
Author
|
Thanks! And no worries on a delay. I've got some more pull requests coming and wanted to make sure I wasn't missing any administrivia sorts of things! |
Contributor
|
Looking forward to them :) On Tue, Oct 20, 2015 at 10:26 PM Kevin Lyda notifications@github.com
|
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Google App Engine does not allow compiling with `import "syscall"`. See discussion in prometheus/client_golang#549 Signed-off-by: Calle Pettersson <calle@cape.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour throws away all stats on any Statfs error. In practice
this is not useful. This turns such errors into debug log messages -
though silently ignoring them seems even more valid to me.
(note this is a suggested partial fix for issue #81 )