ethtool: Add test case with leading spaces #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case for ethtool metrics with leading spaces reported in prometheus#2185: ``` $ ethtool -S NIC statistics: Tx Queue#: 0 TSO pkts tx: 0 TSO bytes tx: 0 ucast pkts tx: 20487 ucast bytes tx: 1908107 mcast pkts tx: 83 mcast bytes tx: 5906 bcast pkts tx: 4 bcast bytes tx: 168 pkts tx err: 0 pkts tx discard: 0 drv dropped tx total: 0 too many frags: 0 giant hdr: 0 hdr err: 0 tso: 0 ring full: 0 pkts linearized: 0 hdr cloned: 0 giant hdr: 0 Rx Queue#: 0 LRO pkts rx: 0 LRO byte rx: 0 ucast pkts rx: 25086 ucast bytes rx: 2404103 mcast pkts rx: 0 mcast bytes rx: 0 bcast pkts rx: 0 bcast bytes rx: 0 pkts rx OOB: 0 pkts rx err: 0 drv dropped rx total: 0 err: 0 fcs: 0 rx buf alloc fail: 0 tx timeout count: 0 ``` Bug: prometheus#2185 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Add test case for ethtool metrics with leading spaces reported in prometheus#2185: ``` $ ethtool -S NIC statistics: Tx Queue#: 0 TSO pkts tx: 0 TSO bytes tx: 0 ucast pkts tx: 20487 ucast bytes tx: 1908107 mcast pkts tx: 83 mcast bytes tx: 5906 bcast pkts tx: 4 bcast bytes tx: 168 pkts tx err: 0 pkts tx discard: 0 drv dropped tx total: 0 too many frags: 0 giant hdr: 0 hdr err: 0 tso: 0 ring full: 0 pkts linearized: 0 hdr cloned: 0 giant hdr: 0 Rx Queue#: 0 LRO pkts rx: 0 LRO byte rx: 0 ucast pkts rx: 25086 ucast bytes rx: 2404103 mcast pkts rx: 0 mcast bytes rx: 0 bcast pkts rx: 0 bcast bytes rx: 0 pkts rx OOB: 0 pkts rx err: 0 drv dropped rx total: 0 err: 0 fcs: 0 rx buf alloc fail: 0 tx timeout count: 0 ``` Bug: prometheus#2185 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Add test case for ethtool metrics with leading spaces reported in prometheus#2185: ``` $ ethtool -S NIC statistics: Tx Queue#: 0 TSO pkts tx: 0 TSO bytes tx: 0 ucast pkts tx: 20487 ucast bytes tx: 1908107 mcast pkts tx: 83 mcast bytes tx: 5906 bcast pkts tx: 4 bcast bytes tx: 168 pkts tx err: 0 pkts tx discard: 0 drv dropped tx total: 0 too many frags: 0 giant hdr: 0 hdr err: 0 tso: 0 ring full: 0 pkts linearized: 0 hdr cloned: 0 giant hdr: 0 Rx Queue#: 0 LRO pkts rx: 0 LRO byte rx: 0 ucast pkts rx: 25086 ucast bytes rx: 2404103 mcast pkts rx: 0 mcast bytes rx: 0 bcast pkts rx: 0 bcast bytes rx: 0 pkts rx OOB: 0 pkts rx err: 0 drv dropped rx total: 0 err: 0 fcs: 0 rx buf alloc fail: 0 tx timeout count: 0 ``` Bug: prometheus#2185 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test case for ethtool metrics with leading spaces reported in #2185: