zfs: Only attempt to pull mibs from supported Releases#3141
Open
dekimsey wants to merge 1 commit intoprometheus:masterfrom
Open
zfs: Only attempt to pull mibs from supported Releases#3141dekimsey wants to merge 1 commit intoprometheus:masterfrom
dekimsey wants to merge 1 commit intoprometheus:masterfrom
Conversation
In particular 14.0 changed the way arcstats were listed, but we previously attempted to grab them all. By adding a bit of a major release detection we reduce the error noise. Signed-off-by: Daniel Kimsey <dekimsey@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular 14.0 changed the way arcstats were listed, but we previously attempted to grab them all. By adding a bit of a major release detection we reduce the error noise.
The collector was still functioning, but FreeBSD users were seeing a large spam of error logs like such:
Instead, the zfs collector will now select the appropriate arcstat metrics for the release. A warning is generated once during start-up if it was unable to determine the OS release.
Resolves #2847
TODOs