infiniband: Handle iWARP* RDMA modules N/A#974
Merged
SuperQ merged 2 commits intoprometheus:masterfrom Oct 4, 2018
Merged
Conversation
discordianfish
requested changes
Jun 23, 2018
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
Thanks for taking a stab at this.
Beside my comment above, the end2end tests are failing.
Member
|
@mjtrangoni Can you look into fixing the tests? Buildkite runs the integration tests and they fail. You should be able to reproduce this locally by running the tests. This is the result: |
Contributor
Author
|
Hi @discordianfish, |
mjtrangoni
force-pushed
the
handle-inactive-iwarp
branch
from
e0001da to
2928a13
Compare
Contributor
Author
|
@discordianfish I can not see what is really happening at buildkite build. How should I do to access its logs? Locally everything is working well, see, BTW, I will be taking a look tomorrow if I can satisfy your previous change request. |
Member
|
Hrmm odd.. Here is the full build log. @SuperQ maybe you have some ideas? |
Contributor
|
Sorry to comment so late, but I figured the following information might be of interest. |
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
mjtrangoni
force-pushed
the
handle-inactive-iwarp
branch
2 times, most recently
from
dd987d2 to
d4221a7
Compare
Contributor
Author
|
@discordianfish I added the |
Member
|
@mjtrangoni The failure was unrelated, kicked off the build again. If that passes, we're good to merge this (except that code comment) @SuperQ Can you have a look? Also: Can we somehow make the buildkite output public? |
Member
|
@discordianfish There's a bunch of long-standing issues with buildkite not having any way to make build output public. 😢 |
This is related to prometheus#966, and handle this error, Jun 07 13:33:24 hostname node_exporter[81888]: time="2018-06-07T13:33:24+02:00" level=error msg="ERROR: infiniband collector failed after 0.000929s: strconv.ParseUint: parsing \"N/A (no PMA)\": invalid syntax" source="collector.go:132" Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
mjtrangoni
force-pushed
the
handle-inactive-iwarp
branch
from
d4221a7 to
4ae03a4
Compare
Contributor
Author
|
@discordianfish PTAL at my comment. buildkite failed again, but it should still be unrelated. |
Contributor
Author
|
@discordianfish ping? I think this could be merged. |
discordianfish
approved these changes
Oct 4, 2018
Member
|
LGTM, @SuperQ wdyt? |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* infiniband: Add not connected i40iw0/ports/1 fixtures * infiniband: Handle issue when iWARP* RDMA modules are not available This is related to prometheus#966, and handle this error, Jun 07 13:33:24 hostname node_exporter[81888]: time="2018-06-07T13:33:24+02:00" level=error msg="ERROR: infiniband collector failed after 0.000929s: strconv.ParseUint: parsing \"N/A (no PMA)\": invalid syntax" source="collector.go:132" Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
PTAL. This should be "handling" #966, where the Intel iWARP RDMA modules are reporting N/A (no PMA) instead of an integer. I added an example to the fixtures, and the end to end tests.