fix: tolerate wrapped signed process counters in /proc/stat#836
Open
happysnaker wants to merge 1 commit into
Open
fix: tolerate wrapped signed process counters in /proc/stat#836happysnaker wants to merge 1 commit into
happysnaker wants to merge 1 commit into
Conversation
Signed-off-by: Shirong Lu <73147033+happysnaker@users.noreply.github.com>
ad2f21b to
f756edc
Compare
Author
|
Follow-up after digging up an older public repro:
So while we still do not have a complete matrix of affected kernels, there is at least one concrete historical kernel string plus one concrete negative I think that is enough to justify the parser hardening here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/statprocessescounters that appear as signed 32-bit decimal stringsWhy
Issue #831 reports systems where
/proc/statexposesprocesses -2045677862, which currently makesparseStat()fail and breaks allStat()consumers. The Linux kernel still formats this field fromtotal_forksusing%lu, but real systems have been observed to surface the wrapped value as a negative decimal string, including priornode_exporterreports in node_exporter#1882.This patch keeps the usual
ParseUintpath for normal hosts, then falls back to parsing a signed 32-bit decimal and reinterpreting it as the original wrappeduint32value. That preserves the underlying counter instead of failing the whole/proc/statparse.