Skip to content

Update dependencies#239

Merged
beorn7 merged 2 commits intomasterfrom
beorn7/dependencies
Oct 2, 2025
Merged

Update dependencies#239
beorn7 merged 2 commits intomasterfrom
beorn7/dependencies

Conversation

@beorn7
Copy link
Copy Markdown
Member

@beorn7 beorn7 commented Oct 2, 2025

@SuperQ @krajorama easy review. May I get it from one of you?

beorn7 added 2 commits October 2, 2025 14:58
Signed-off-by: beorn7 <beorn@grafana.com>
This adjusts to the prometheus/common behavior introduced in v0.66.

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 requested review from SuperQ and krajorama October 2, 2025 13:26
Copy link
Copy Markdown
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unsure about defaulting to UTF-8 validation, but I guess it's fine. cc @ywwg

@beorn7
Copy link
Copy Markdown
Member Author

beorn7 commented Oct 2, 2025

prom2json actually doesn't validate anything. It simply converts to JSON whatever we feed it. That was always the case. It's a very simple tool.

(However, we need to allow activating UTF-8 in content negotiation, which I just realized. PR incoming.)

@beorn7 beorn7 merged commit 0e00d86 into master Oct 2, 2025
5 checks passed
@beorn7 beorn7 deleted the beorn7/dependencies branch October 2, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants