refactor: move from io/ioutil to io and os packages#10528
Merged
roidelapluie merged 3 commits intoprometheus:mainfrom Apr 27, 2022
mmorel-35:ioutil
Merged
refactor: move from io/ioutil to io and os packages#10528roidelapluie merged 3 commits intoprometheus:mainfrom mmorel-35:ioutil
roidelapluie merged 3 commits intoprometheus:mainfrom
mmorel-35:ioutil
Conversation
mmorel-35
requested review from
JessicaGreben,
brancz,
bwplotka,
codesome,
csmarchbanks,
cstyan,
dgl,
roidelapluie and
tomwilkie
as code owners
Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>
Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>
metalmatze
reviewed
Apr 4, 2022
Member
metalmatze
left a comment
metalmatze
left a comment
There was a problem hiding this comment.
Very nice, no surprises in the code! 👍
There seems to be either a flaky test or something slightly off with moving to the other/new Temp funcs:
https://app.circleci.com/pipelines/github/prometheus/prometheus/16508/workflows/301b1fdb-1683-4997-9bdd-e6fbc7d15565/jobs/79014?invite=true#step-103-18
mmorel-35
commented
Apr 4, 2022
Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>
cstyan
approved these changes
Apr 4, 2022
metalmatze
approved these changes
Apr 5, 2022
Contributor
Author
|
Hi! What is blocking the merge? Are you expecting me to do anything else? |
Member
|
Thanks! |
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 22, 2022
* refactor: move from io/ioutil to io and os packages * use fs.DirEntry instead of os.FileInfo after os.ReadDir Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In go 1.16 io/ioutil package is deprecated, see https://go.dev/doc/go1.16#ioutil