Skip to content

Fix exemplar docs.#10609

Merged
Nexucis merged 1 commit intoprometheus:mainfrom
JokerQueue:main
Apr 21, 2022
Merged

Fix exemplar docs.#10609
Nexucis merged 1 commit intoprometheus:mainfrom
JokerQueue:main

Conversation

@JokerQueue
Copy link
Copy Markdown
Contributor

The structure of the config "storage. exemplars" is not a list.

storage:
  exemplars:
    max_exemplars: 100000

So I think the doc should be

[ exemplars: <exemplars> ]

but not

[ - <exemplars> ... ]

@Nexucis
Copy link
Copy Markdown
Member

Nexucis commented Apr 20, 2022

Hello, thanks for your contribution.

DCO failed because for legal reason we are asking to contributor to signoff every commits. Can you follow the procedure indicated by DCO https://github.com/prometheus/prometheus/pull/10609/checks?check_run_id=6088325808 please ?

Once it is done I think we can merge it :)
Thanks.

Signed-off-by: Joker <joker9764@126.com>
@JokerQueue
Copy link
Copy Markdown
Contributor Author

Done.

@Nexucis
Copy link
Copy Markdown
Member

Nexucis commented Apr 21, 2022

thanks @JokerQueue !

@Nexucis Nexucis merged commit b2c2143 into prometheus:main Apr 21, 2022
roidelapluie pushed a commit to roidelapluie/prometheus that referenced this pull request Jun 22, 2022
Signed-off-by: Joker <joker9764@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants