Merged
Conversation
Member
|
Hello, thanks for your contribution. DCO failed because for legal reason we are asking to contributor to signoff every commits. Can you follow the procedure indicated by DCO https://github.com/prometheus/prometheus/pull/10609/checks?check_run_id=6088325808 please ? Once it is done I think we can merge it :) |
Signed-off-by: Joker <joker9764@126.com>
Contributor
Author
|
Done. |
Member
|
thanks @JokerQueue ! |
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 22, 2022
Signed-off-by: Joker <joker9764@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The structure of the config "storage. exemplars" is not a list.
So I think the doc should be
but not