test(rw2): add nhcb testcases to remote write 2.0#16409
Merged
Conversation
Ref: #15021 Also modified spansToSpansProto to not allocate empty bucket spans array when converting internal model to remote write model. Otherwise the test TestDecodeWriteV2Request fails since empty array is marshaled/unmarshaled as nil so we don't get back the exact same thing. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
commented
Apr 8, 2025
krajorama
commented
Apr 8, 2025
jesusvazquez
reviewed
Apr 8, 2025
jesusvazquez
approved these changes
Apr 8, 2025
Member
jesusvazquez
left a comment
jesusvazquez
left a comment
There was a problem hiding this comment.
LGTM left a tiny question but the rest of the changes look legit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #15021
Also modified spansToSpansProto to not allocate empty bucket spans array when converting internal model to remote write model. Otherwise the test TestDecodeWriteV2Request fails since empty array is marshaled/unmarshaled as nil so we don't get back the exact same thing.