promql: fix info() handling of negated __name__ matchers#17932
Merged
Conversation
8f15536 to
17e579f
Compare
17e579f to
5d3f28a
Compare
zenador
reviewed
Jan 26, 2026
5d3f28a to
272e50b
Compare
272e50b to
f18a1f7
Compare
zenador
reviewed
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Code looks good, thank you! The previous comments can be resolved (I don't have the permissions to do so.) I just have some concerns about the defined behaviour.
- The (invisible to user) adding of
~=".+_info"as a matcher when there are only negative matchers is surprising behaviour. I think it makes sense to do this (if the convention is for all info metrics to have that suffix and it's generally followed), but since it's surprising it needs to be clearly explained in the docs. - The logic for which series are retrieved as info series currently does not exactly match the logic for the ignored series. I came up with a contrived test case below to show how this could potentially be confusing. It's not a huge deal since the user can add more matchers to the first argument to get around this, but it just seems more intuitive to have the distinction between queried metrics and info series be consistent within a query (and not have any series be treated as neither or both).
load 5m
websvc_thing{instance="a", job="1", label="value"} 0 1 2
websvc_stuff_info{instance="a", job="1", build_data="build"} 1 1 1
target_info{instance="a", job="1", data="info", another_data="another info"} 1 1 1
# websvc_stuff_info is ambiguously named, but when meant to be info series rather than regular metric, it works okay
eval range from 0m to 10m step 5m info({__name__=~"websvc_.+"}, {__name__=~".+_info"})
websvc_thing{instance="a", job="1", label="value", data="info", another_data="another info", build_data="build"} 0 1 2
websvc_stuff_info{instance="a", job="1", build_data="build"} 1 1 1
clear
load 5m
websvc_thing{instance="a", job="1", label="value"} 0 1 2
websvc_stuff_info{instance="a", job="1", build_data="build"} 2 3 4
target_info{instance="a", job="1", data="info", another_data="another info"} 1 1 1
# websvc_stuff_info is ambiguously named, but when meant to be regular metric rather than info series, it doesn't work as expected currently, as it is treated as neither metric nor info series. the following is the expected result with it being treated as a regular metric, but the test fails
eval range from 0m to 10m step 5m info({__name__=~"websvc_.+"}, {__name__=~".+_info", __name__!~"websvc_.+"})
websvc_thing{instance="a", job="1", label="value", data="info", another_data="another info"} 0 1 2
websvc_stuff_info{instance="a", job="1", build_data="build", data="info", another_data="another info"} 2 3 4
f18a1f7 to
6d94eab
Compare
Contributor
Author
|
@zenador Thank you for raising those concerns. Can you PTAL at the latest revision? |
e201ec5 to
b903cfb
Compare
zenador
approved these changes
Mar 25, 2026
Contributor
zenador
left a comment
There was a problem hiding this comment.
LGTM, thank you very much! Only thing left is to update the docs, but that can also be done separately.
b903cfb to
040fe90
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
The previous fix used a single positiveNameMatcher pointer, which silently kept only the last positive matcher when multiple were specified. Change to a slice so all positive matchers are applied. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
When negative __name__ matchers were combined with positive ones, ignoreSeries only checked positive matchers while fetchInfoSeries applied both. This caused series matching positive matchers but excluded by negative matchers to vanish from results entirely. Align ignoreSeries with fetchInfoSeries by building the same effective matcher set (including negative matchers and the implicit .+_info fallback) and checking all matchers. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
040fe90 to
4e63d3a
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
ddb420c to
a0504db
Compare
rbizos
pushed a commit
to rbizos/prometheus
that referenced
this pull request
Apr 29, 2026
…17932) * promql: fix info() handling of negated __name__ matchers --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Raphael Bizos <r.bizos@criteo.com>
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
May 28, 2026
…➔ v3.12.0) (#730) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/prometheus](https://github.com/prometheus/prometheus) | minor | `v3.11.3` → `v3.12.0` | --- ### Release Notes <details> <summary>prometheus/prometheus (quay.io/prometheus/prometheus)</summary> ### [`v3.12.0`](https://github.com/prometheus/prometheus/releases/tag/v3.12.0): 3.12.0 / 2026-05-28 [Compare Source](prometheus/prometheus@v3.11.3...v3.12.0) - \[SECURITY] Remote-write: Reject snappy-compressed requests whose declared decoded length exceeds the 32MB. Thanks to [@​hibrian827](https://github.com/hibrian827) for reporting it. [#​18642](prometheus/prometheus#18642) - \[SECURITY] STACKIT SD: Fix secrets being exposed in plaintext via `/-/config` endpoint. Thanks to [@​August829](https://github.com/August829) and [@​Phaxma](https://github.com/Phaxma) for reporting. GHSA-39j6-789q-qxvh [#​18649](prometheus/prometheus#18649) - \[CHANGE] TSDB/Agent: Adds Start Timestamp field to all WAL Histogram samples in memory; used `st-storage` flag is enabled. [#​18221](prometheus/prometheus#18221) - \[FEATURE] API: Add `/api/v1/status/self_metrics` endpoint returning the current state of the Prometheus server's own metrics about itself as JSON. [#​18411](prometheus/prometheus#18411) - \[FEATURE] Discovery: Add DigitalOcean Managed Databases service discovery [#​18287](prometheus/prometheus#18287) - \[FEATURE] Prometheus: Add support for the aix/ppc64 compilation target [#​18321](prometheus/prometheus#18321) - \[FEATURE] Discovery: Add Outscale VM service discovery (`outscale_sd_configs`) for discovering scrape targets from the Outscale Cloud API. [#​18139](prometheus/prometheus#18139) - \[FEATURE] PromQL: Emit a warning when `sort`, `sort_by_label` or `sort_by_label_desc` is used within range (matrix) queries, as these functions do not have effect in that context. [#​18498](prometheus/prometheus#18498) - \[FEATURE] PromQL: Add `start()`, `end()`, `range()`, and `step()` experimental functions [#​17877](prometheus/prometheus#17877) - \[FEATURE] PromQL: Update `resets()` function to consider start timestamp resets. Hidden behind `use-start-timestamps` feature flag. [#​18627](prometheus/prometheus#18627) - \[FEATURE] Prometheus: Promote auto-reload-config as stable [#​18620](prometheus/prometheus#18620) - \[FEATURE] TSDB/Agent: Add `CheckpointFromInMemorySeries` option to `agent.DB` that enables checkpoint based on in-memory series. [#​17948](prometheus/prometheus#17948) - \[FEATURE] UI: Add a web interface for deleting time series and cleaning tombstones, accessible from the Status menu. [#​18390](prometheus/prometheus#18390) - \[FEATURE] PromQL: Use start timestamps for `rate()`, `irate(), and `increase()`calculations, behind a feature flag`use-start-timestamps`. Doesn't work together with extended range selectors `anchored`and`smoothed\`. [#​18344](prometheus/prometheus#18344) - \[FEATURE] Scrape: Added a feature flag `st-synthesis` which synthesizes unknown STs for scraped cumulative metrics. Useful when Remote Writing 2.0 with delta or Otel-based backends. [#​18279](prometheus/prometheus#18279) - \[FEATURE] promqltest: support `@st` annotation in `load` blocks to specify per-sample start timestamps. [#​18360](prometheus/prometheus#18360) - \[ENHANCEMENT] API: reject concurrent fgprof profiles. [#​18651](prometheus/prometheus#18651) - \[ENHANCEMENT] AWS SD: Add optional `external_id` field to ECS/MSK/RDS/Elasticache. [#​18579](prometheus/prometheus#18579) - \[ENHANCEMENT] AWS SD: Add optional `external_id` field. [#​17171](prometheus/prometheus#17171) - \[ENHANCEMENT] Discovery: Propagate SD target updates faster by introducing dynamic backoff interval instead of static 5s interval for throttling. [#​18187](prometheus/prometheus#18187) - \[ENHANCEMENT] Promtool: Add `--header` flag to `query instant` command, matching existing `query range` behaviour. [#​18418](prometheus/prometheus#18418) - \[ENHANCEMENT]: AWS SD: Allows EC2 service discovery to discover IPv6 addresses to communicate with target endpoints. The private IPv4 address remains the default when both IPv4 and IPv6 addresses are present. [#​16088](prometheus/prometheus#16088) - \[PERF] TSDB: Make head chunk lookup in range queries constant time instead of quadratic time [#​18302](prometheus/prometheus#18302) - \[PERF] TSDB: Skip entire stripes in mmapHeadChunks when no series need mmapping, reducing CPU utilization significantly at production-relevant scales. [#​18541](prometheus/prometheus#18541) - \[PERF] TSDB: Skip clean series during periodic head chunk mmap using cached head chunk count [#​18272](prometheus/prometheus#18272) - \[PERF] PromQL: Address FloatHistogram.KahanAdd performance regression on Go 1.26. [#​18568](prometheus/prometheus#18568) - \[BUGFIX] PromQL: Fix `info()` function incorrectly handling negated `__name__` matchers [#​17932](prometheus/prometheus#17932) - \[BUGFIX] API: Return duration expressions in `/parse_ast`. [#​18624](prometheus/prometheus#18624) - \[BUGFIX] API: correctly document formats accepted for duration query request parameters (step, timeout and lookback delta) in OpenAPI spec [#​18305](prometheus/prometheus#18305) - \[BUGFIX] Scrape: AppenderV2 now tracks staleness even when OOO/duplicate series errors happen similar to AppenderV1 [#​18567](prometheus/prometheus#18567) - \[BUGFIX] Config: Validate remote\_write queue\_config fields at load time to prevent runtime panic and silent misconfiguration. [#​18209](prometheus/prometheus#18209) - \[BUGFIX] Discovery/Consul: Add `health_filter` for Health API filtering, fixing breakage when using Catalog-only fields like `ServiceTags` in `filter`. [#​18479](prometheus/prometheus#18479) [#​18499](prometheus/prometheus#18499) - \[BUGFIX] OTLP: limit decompressed body size for gzip-encoded OTLP write requests. [#​18408](prometheus/prometheus#18408) - \[BUGFIX] PromQL: Fix `smoothed` rate/increase returning zero instead of no result when all data falls strictly after the query range. [#​18523](prometheus/prometheus#18523) - \[BUGFIX] PromQL: Fix metric name not being dropped when last\_over\_time or first\_over\_time is applied to subqueries containing name-dropping functions like abs(). [#​18409](prometheus/prometheus#18409) - \[BUGFIX] PromQL: Fix missing warning when mixing exponential and custom-bucket histograms in stats queries. [#​18660](prometheus/prometheus#18660) - \[BUGFIX] PromQL: Fix parsing of `range()` keyword in duration expressions such as `foo[5m+range()]`. [#​18623](prometheus/prometheus#18623) - \[BUGFIX] PromQL: Fix smoothed vector selector returning no results in binary operations when the `@` modifier is used. [#​18531](prometheus/prometheus#18531) - \[BUGFIX] PromQL: Reject NaN, infinite, and out-of-range duration expressions instead of silently producing an out-of-range time.Duration. [#​18639](prometheus/prometheus#18639) - \[BUGFIX] Scrape: Fix panic when scraping malformed native histograms. [#​18414](prometheus/prometheus#18414) - \[BUGFIX] Scrape: fix panic when scraping a target exposing a summary with no quantiles via the protobuf format. [#​18382](prometheus/prometheus#18382) - \[BUGFIX] Scrape: fix scrape failure log file occasionally not applied after a configuration reload. [#​18421](prometheus/prometheus#18421) - \[BUGFIX] TSDB: Allow retention percentage with new data path. [#​18628](prometheus/prometheus#18628) - \[BUGFIX] TSDB: Preserve decimal precision in percentage-based retention [#​18374](prometheus/prometheus#18374) - \[BUGFIX] TSDB: fix prometheus\_tsdb\_head\_chunks going negative after WAL replay [#​18401](prometheus/prometheus#18401) - \[BUGFIX] TSDB: panic with native histograms during query of overlapping chunks. [#​18692](prometheus/prometheus#18692) - \[BUGFIX] Tracing: fix startup failure for insecure OTLP HTTP tracing [#​18469](prometheus/prometheus#18469) - \[BUGFIX] UI: Escape label values offered by PromQL autocomplete. [#​18658](prometheus/prometheus#18658) - \[BUGFIX] UI: Improve Y-axis tick label precision for graph values over small ranges. [#​18682](prometheus/prometheus#18682) - \[BUGFIX] `prometheus_sd_refresh*` and `prometheus_sd_discovered_targets` metrics for specific scrape jobs are deleted when the scrape job is removed. [#​17614](prometheus/prometheus#17614) - \[BUGFIX] Remote: fixed validation for received RW2 requests when parsing metadata unit symbols. This fixes a case when request would cause (recovered) handler panic. [#​18641](prometheus/prometheus#18641) - \[BUGFIX] TSDB/Agent: fix race in agent appender where concurrent appends for the same label set could produce duplicate in-memory series and duplicate WAL records. [#​18292](prometheus/prometheus#18292) - \[BUGFIX] Config: Update `--enable-feature` flag description and sort feature names. [#​18487](prometheus/prometheus#18487) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Fixes #17931
Does this PR introduce a user-facing change?
Fix how the
info()function handles__name__matchers in the second argument:Negated matchers no longer break
ignoreSeries: Previously, negated matchers (!=,!~) could cause base metrics to be incorrectly added toignoreSeries, or cause series to vanish when they matched positive matchers but were excluded by negative ones. NowignoreSeriesuses the same resolved matcher set as the info series fetch, viaeffectiveInfoNameMatchers.Negated-only
__name__matchers select info metrics correctly: When only negated__name__matchers are provided, a broad.+_infopattern is used to select info metrics, then the negative matchers filter them. Previously, negated matchers alone would incorrectly select non-info metrics as info sources.Multiple positive
__name__matchers are supported: All positive__name__matchers are applied with AND semantics. Previously, only the last one was kept.