Scrollbar mouse support #1587
Open
Scrollbar mouse support #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @joouha, thanks for this! Many good things here. Can you already apply "black" so that the pipeline will pass? |
joouha
force-pushed
the
scrollbar-mouse-support
branch
from
df59760 to
7b78902
Compare
Contributor
Author
|
Done! |
joouha
force-pushed
the
scrollbar-mouse-support
branch
2 times, most recently
from
c0cc874 to
d42b612
Compare
Squashed fixes: - Do not allow scrollbar thumb beyond track limits - Hide thumb but show track & arrows if we cannot scroll. - This replicates the original behaviour of the scrollbar margin. - Prevent division-by-zero error - Fix typing
joouha
force-pushed
the
scrollbar-mouse-support
branch
from
d42b612 to
516df10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for mouse events in window margins (fixing #236)
It also adds mouse support for
ScrollBarMargin(fixing #284).I've also implemented smoother scrollbar movement using block characters.
Here is a quick video showing the updated
ScrollBarMarginPeek.2022-03-08.10-31.mp4