Skip to content

Conversation

@utabe
Copy link

@utabe utabe commented Aug 12, 2019

Add support for issue Long names 909.

@utabe
Copy link
Author

utabe commented Aug 14, 2019

@jonathanslenders what would need to be added to this in order for it to mergeable?

@mlucool
Copy link

mlucool commented Nov 29, 2019

@jonathanslenders Any objection to this request?

@mlucool
Copy link

mlucool commented Jan 15, 2020

@jonathanslenders just wanted to reach out again to see your thoughts on this

@ngoldbaum
Copy link

@jonathanslenders any chance this one can get some code review?

@asmeurer
Copy link
Contributor

asmeurer commented Mar 3, 2020

I just tested this and it works. It makes more sense for ... to go at the beginning because the beginning of the completion is already there in the text that was typed.

@jonathanslenders
Copy link
Member

Thanks for this! (And thanks for the patience, it's been super busy.)

I think usually it does make sense indeed, but not always. There are situations where we have to complete long filenames with many pieces in common, where nothing was typed yet. for instance:

____________a__________1_________
____________a__________2_________
____________b__________1_________
____________b__________2_________
etc...

People type this by tabbing the common pieces and typing the things that are different. If we truncate on the left, this won't work anymore. So, this will break some people's workflow.

I'll see if it's feasible to have dots on the left if the start of the completion was already typed. If too difficult, I should probably merge this.

@asmeurer
Copy link
Contributor

asmeurer commented Mar 4, 2020

Another option might be to show both the part right after what is typed as well as the end, and have the ellipses in the middle. I don't know how hard that is to do.

@jonathanslenders
Copy link
Member

Related issue: #909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants