Skip to content

feat: full hook coverage for Claude Code and Cursor (+ fix WorktreeCreate breakage) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthavird merged 2 commits into from
May 11, 2026
Merged

feat: full hook coverage for Claude Code and Cursor (+ fix WorktreeCreate breakage) #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ffc4e9
feat(cursor): register for all 20 hook events from the current spec
claude May 11, 2026
8b9f818
feat(claude-code): full hook coverage + remove buggy WorktreeCreate r…
claude May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 111 additions & 24 deletions cmd/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,17 @@ func installClaudeCode(exePath string) error {
hookCmd := fmt.Sprintf("%s hook", exePath)
hooks := buildClaudeCodeHooks(hookCmd)

// Merge hooks into settings
// Strip any of OUR previously-installed hook entries first so events we
// no longer ship (e.g. WorktreeCreate, which we used to register but now
// deliberately skip) get cleaned up rather than lingering forever. Any
// hook whose value doesn't reference "promptconduit" is left alone —
// that's the user's own configuration.
if existingHooks, ok := settings["hooks"].(map[string]interface{}); ok {
for name, config := range existingHooks {
if containsPromptConduit(config) {
delete(existingHooks, name)
}
}
for name, config := range hooks {
existingHooks[name] = config
}
Expand Down Expand Up @@ -112,6 +121,20 @@ func installClaudeCode(exePath string) error {
return nil
}

// buildClaudeCodeHooks registers for every event in the current Claude Code
// hooks reference (https://code.claude.com/docs/en/hooks) except for
// WorktreeCreate. Configuring a WorktreeCreate hook *replaces* the default
// `git worktree` behavior — Claude Code expects the hook to print the
// new worktree path on stdout, but our hook handler always prints
// `{"continue": true}`, which would cause `claude --worktree` and
// `isolation: "worktree"` subagents to fail outright. Until our hook
// handler can detect WorktreeCreate events and behave correctly (return
// the path), we don't register for that event.
//
// Matchers on no-matcher events (TaskCreated, TaskCompleted, TeammateIdle,
// PostToolBatch, etc.) are silently ignored per the spec, so we use
// `makeHook` for those rather than `makeMatcherHook` to keep the
// settings.json output tidy.
func buildClaudeCodeHooks(hookCmd string) map[string]interface{} {
makeHook := func(timeout int) []map[string]interface{} {
return []map[string]interface{}{
Expand All @@ -132,37 +155,44 @@ func buildClaudeCodeHooks(hookCmd string) map[string]interface{} {
}
}

plainEvent := func() []map[string]interface{} {
return []map[string]interface{}{{"hooks": makeHook(5000)}}
}

return map[string]interface{}{
// Session lifecycle
"SessionStart": []map[string]interface{}{{"hooks": makeHook(5000)}},
"SessionEnd": []map[string]interface{}{{"hooks": makeHook(5000)}},
"SessionStart": plainEvent(),
"Setup": plainEvent(), // --init-only / -p --init / -p --maintenance
"SessionEnd": plainEvent(),
// Per-turn events
"UserPromptSubmit": []map[string]interface{}{{"hooks": makeHook(5000)}},
"Stop": []map[string]interface{}{{"hooks": makeHook(5000)}}, // Agent completes response
"StopFailure": []map[string]interface{}{{"hooks": makeHook(5000)}}, // Turn ends due to API error
// Tool execution events
"UserPromptSubmit": plainEvent(),
"UserPromptExpansion": plainEvent(), // slash-command expansion path
"Stop": plainEvent(), // Agent completes response
"StopFailure": plainEvent(), // Turn ends due to API error
// Tool execution events (matchers filter on tool name)
"PreToolUse": makeMatcherHook(5000),
"PostToolUse": makeMatcherHook(5000),
"PostToolUseFailure": makeMatcherHook(5000),
"PostToolBatch": plainEvent(), // no matcher support — fires once per batch
"PermissionRequest": makeMatcherHook(5000),
"PermissionDenied": makeMatcherHook(5000), // Auto mode denies a tool call
// Agent and task events
"SubagentStart": makeMatcherHook(5000),
"SubagentStart": makeMatcherHook(5000), // matcher filters on agent type
"SubagentStop": makeMatcherHook(5000),
"TaskCreated": makeMatcherHook(5000),
"TaskCompleted": makeMatcherHook(5000),
"TeammateIdle": makeMatcherHook(5000),
"TaskCreated": plainEvent(), // no matcher support
"TaskCompleted": plainEvent(), // no matcher support
"TeammateIdle": plainEvent(), // no matcher support
// File and configuration events
"InstructionsLoaded": []map[string]interface{}{{"hooks": makeHook(5000)}}, // CLAUDE.md loaded
"ConfigChange": []map[string]interface{}{{"hooks": makeHook(5000)}},
"CwdChanged": []map[string]interface{}{{"hooks": makeHook(5000)}},
"FileChanged": []map[string]interface{}{{"hooks": makeHook(5000)}},
"InstructionsLoaded": plainEvent(), // CLAUDE.md / .claude/rules/*.md loaded
"ConfigChange": plainEvent(),
"CwdChanged": plainEvent(),
"FileChanged": plainEvent(),
// Context compaction events
"PreCompact": []map[string]interface{}{{"hooks": makeHook(5000)}},
"PostCompact": []map[string]interface{}{{"hooks": makeHook(5000)}},
"WorktreeCreate": []map[string]interface{}{{"hooks": makeHook(5000)}},
"WorktreeRemove": []map[string]interface{}{{"hooks": makeHook(5000)}},
// MCP events
"PreCompact": plainEvent(),
"PostCompact": plainEvent(),
// Worktree (only Remove — see Create note in function comment)
"WorktreeRemove": plainEvent(),
// MCP events (matcher filters on MCP server name)
"Elicitation": makeMatcherHook(5000),
"ElicitationResult": makeMatcherHook(5000),
// Notifications
Expand Down Expand Up @@ -190,8 +220,17 @@ func installCursor(exePath string) error {
hookCmd := fmt.Sprintf("%s hook", exePath)
hooks := buildCursorHooks(hookCmd)

// Merge hooks into settings
// Strip any of OUR previously-installed hook entries first so events we
// no longer ship (e.g. WorktreeCreate, which we used to register but now
// deliberately skip) get cleaned up rather than lingering forever. Any
// hook whose value doesn't reference "promptconduit" is left alone —
// that's the user's own configuration.
if existingHooks, ok := settings["hooks"].(map[string]interface{}); ok {
for name, config := range existingHooks {
if containsPromptConduit(config) {
delete(existingHooks, name)
}
}
for name, config := range hooks {
existingHooks[name] = config
}
Expand Down Expand Up @@ -221,6 +260,18 @@ func installCursor(exePath string) error {
return nil
}

// buildCursorHooks registers for every event the current Cursor agent + Tab
// hooks spec exposes (https://cursor.com/docs/hooks). Agent hooks cover the
// Cmd+K / Agent Chat flow; Tab hooks cover inline-completion autonomous
// edits, which deliberately get a separate policy from user-directed Agent
// operations.
//
// We register both the generic `preToolUse`/`postToolUse` AND the
// specific-tool variants (`beforeShellExecution`, `beforeMCPExecution`,
// `beforeReadFile`, `afterFileEdit`). The specific events are richer
// (they carry the actual command / file path / MCP server), and the
// generic ones backfill any tool category that doesn't have a dedicated
// hook. The platform dedupes server-side by event id.
func buildCursorHooks(hookCmd string) map[string]interface{} {
makeHook := func() []map[string]interface{} {
return []map[string]interface{}{
Expand All @@ -229,10 +280,37 @@ func buildCursorHooks(hookCmd string) map[string]interface{} {
}

return map[string]interface{}{
"beforeSubmitPrompt": makeHook(),
// Session lifecycle
"sessionStart": makeHook(),
"sessionEnd": makeHook(),
// Generic tool use (fires for every tool, including the specific
// ones below; we keep both for coverage of unknown tool kinds)
"preToolUse": makeHook(),
"postToolUse": makeHook(),
"postToolUseFailure": makeHook(),
// Subagent (Task tool) lifecycle
"subagentStart": makeHook(),
"subagentStop": makeHook(),
// Shell command execution
"beforeShellExecution": makeHook(),
"afterShellExecution": makeHook(),
"afterFileEdit": makeHook(),
// MCP tool execution
"beforeMCPExecution": makeHook(),
"afterMCPExecution": makeHook(),
// File access and edits
"beforeReadFile": makeHook(),
"afterFileEdit": makeHook(),
// Prompts and agent output
"beforeSubmitPrompt": makeHook(),
"afterAgentResponse": makeHook(),
"afterAgentThought": makeHook(),
// Context window
"preCompact": makeHook(),
// Stop
"stop": makeHook(),
// Tab (inline completions) — separate policy from Agent operations
"beforeTabFileRead": makeHook(),
"afterTabFileEdit": makeHook(),
}
}

Expand All @@ -256,8 +334,17 @@ func installGemini(exePath string) error {
hookCmd := fmt.Sprintf("%s hook", exePath)
hooks := buildGeminiHooks(hookCmd)

// Merge hooks into settings
// Strip any of OUR previously-installed hook entries first so events we
// no longer ship (e.g. WorktreeCreate, which we used to register but now
// deliberately skip) get cleaned up rather than lingering forever. Any
// hook whose value doesn't reference "promptconduit" is left alone —
// that's the user's own configuration.
if existingHooks, ok := settings["hooks"].(map[string]interface{}); ok {
for name, config := range existingHooks {
if containsPromptConduit(config) {
delete(existingHooks, name)
}
}
for name, config := range hooks {
existingHooks[name] = config
}
Expand Down
Loading