Add failing tests for #364: Cumulative cost display bug #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unit tests in test_fix_code_loop.py to verify Total Cost includes prior operation costs - Add E2E tests in test_e2e_issue_364_cumulative_cost.py to test integration-level behavior Tests are designed to fail on current code (demonstrating the bug) and pass once the fix is implemented. The bug is that fix_code_loop displays only loop-local costs instead of cumulative costs including prior operations (like auto-deps). Refs #364 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Enfoirer
pushed a commit
to Enfoirer/pdd
that referenced
this pull request
Jan 24, 2026
Add failing tests for promptdriven#364: Cumulative cost display bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing tests that detect the bug reported in #364.
Test Files
tests/test_fix_code_loop.py(TestCumulativeCostDisplay class)tests/test_e2e_issue_364_cumulative_cost.pyWhat This PR Contains
Root Cause
The
fix_code_loopfunction inpdd/fix_code_loop.pyinitializes a localtotal_cost = 0.0variable (line 442) and displays only this loop-local cost (line 684). When auto-deps costs $3 before the fix loop runs, the displayed "Total Cost: $0.50" is misleading - it should show the cumulative "$3.50".The budget enforcement is correct (it properly passes
budget - prior_cost), but the display is misleading because it doesn't include prior operation costs.Next Steps
prior_costparameter tofix_code_loop()andfix_verification_errors_loop()prior_cost + total_costas "Total Cost"Fixes #364
Generated by PDD agentic bug workflow