feat(court): enhance reviewer and judge prompts to catch silent data corruption#31
Merged
MrFlounder merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
…corruption patterns Adds 4 high-risk pattern checks to both reviewer agent prompts and the judge's own investigation phase, derived from the PR #3232 incident where a clean-looking diff caused mass data corruption through called-but-not-changed code. Reviewers now actively check for: 1. Called-but-not-changed code contracts (trace into called functions) 2. Mutations on read paths (writes triggered by GET endpoints) 3. Blast radius from null/default initial state (mass rewrites on first access) 4. Data contract completeness at merge/spread boundaries (missing fields) The judge also proactively investigates these patterns even if neither reviewer flagged them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 20, 2026
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
PR #3232 (
refreshMetricsIfStale()) caused mass data corruption because:MetricsCalculationService.calculate()which was called but not changed in the diffnullmetricsRefreshedAt, so every record got hit on first viewNone of these were visible in the diff alone. The current reviewer prompts only say "review for bugs, security issues, and code quality" — too generic to catch this class of issue.
Test plan
crab courton a test PR and verify both reviewers mention the new checks in their findings🤖 Generated with Claude Code