Skip to content

[codex] fix ci success on main pushes#81

Merged
jbeckwith-oai merged 1 commit intomainfrom
mdangelo/codex/fix-ci-success-main-push
Apr 1, 2026
Merged

[codex] fix ci success on main pushes#81
jbeckwith-oai merged 1 commit intomainfrom
mdangelo/codex/fix-ci-success-main-push

Conversation

@mldangelo-oai
Copy link
Copy Markdown
Contributor

Summary

test workflow runs on direct pushes to main are failing in the aggregate CI Success job even when this repo's Unit tests (bats) and Shellcheck jobs pass.

Root cause

CI Success uses the shared promptfoo/.github action that waits for all checks on the commit. That is the right behavior for pull requests, but on push events to main the same commit can also have unrelated branch-level checks such as Dependabot and CodeQL checks. In the failing run for 9b1c42b, Dependabot completed with failure, so CI Success failed this workflow despite the repo-local jobs passing.

Fix

Keep CI Success for pull_request events, but skip it on push events. The repo-local unit and lint jobs still run on pushes to main, and the workflow result now reflects those jobs instead of unrelated checks.

Validation

  • make test-unit
  • shellcheck --severity=error src/crabcode

@mldangelo-oai mldangelo-oai marked this pull request as ready for review April 1, 2026 18:11
@jbeckwith-oai jbeckwith-oai merged commit 23891bc into main Apr 1, 2026
6 checks passed
@jbeckwith-oai jbeckwith-oai deleted the mdangelo/codex/fix-ci-success-main-push branch April 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants