Skip to content

refactor(ci): add shared ci success#41

Merged
jbeckwith-oai merged 1 commit intomainfrom
codex/add-ci-success
Mar 23, 2026
Merged

refactor(ci): add shared ci success#41
jbeckwith-oai merged 1 commit intomainfrom
codex/add-ci-success

Conversation

@jbeckwith-oai
Copy link
Copy Markdown
Contributor

Update the existing Promptfoo Code Scan workflow so it reruns on synchronize and reopened pull request events, and add a CI Success job that uses the shared first-party action from promptfoo/.github. This keeps the current security scan job intact while giving the repo a single required status check path. Test plan: verify the updated workflow parses and CI Success waits for the security scan on PRs.

Co-authored-by: Codex <noreply@openai.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4e40b8bd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


steps:
- name: Wait for all PR checks to succeed
uses: promptfoo/.github/.github/actions/ci-success@main
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin ci-success action to an immutable revision

Avoid referencing promptfoo/.github/.github/actions/ci-success with @main. A mutable branch means any future upstream change (or compromise) can silently alter this repo’s CI behavior and required-check outcome. This is a supply-chain integrity risk in the workflow itself; pin to a full commit SHA (or another immutable ref) and update deliberately.

Useful? React with 👍 / 👎.

@jbeckwith-oai jbeckwith-oai merged commit 71f29eb into main Mar 23, 2026
5 checks passed
@jbeckwith-oai jbeckwith-oai deleted the codex/add-ci-success branch March 23, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant