Skip to content

fix(cli): handle startup interrupts gracefully#1723

Merged
mldangelo-oai merged 2 commits into
mainfrom
fix/cli-startup-interrupt
Jul 2, 2026
Merged

fix(cli): handle startup interrupts gracefully#1723
mldangelo-oai merged 2 commits into
mainfrom
fix/cli-startup-interrupt

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Contributor

Summary: handle SIGINT during CLI imports and pre-scan startup without a raw traceback or generic Click abort; add deterministic entrypoint regression coverage; document the user-visible fix. Validation: focused interrupt suite passed (4 tests); targeted ruff, format, and mypy passed; repo-wide ruff passed. Broad mypy remains blocked by unrelated baseline errors, and broad pytest by the local venv missing modelaudit_picklescan._rust.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Workflow run and artifacts

Performance Benchmarks

Compared 13 shared benchmarks with a regression threshold of 15%.
Status: 0 regressions, 0 improved, 13 stable, 0 new, 0 missing.
Aggregate shared-benchmark median: 4.343s -> 4.412s (+1.6%).

Workload Benchmark Target Size Files Baseline Current Change Status
chunked-upload-stream tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_chunked_upload_stream chunked_stream 278.2 KiB 1 111.24ms 115.77ms +4.1% stable
warm-cache-rescan tests/benchmarks/test_scan_benchmarks.py::test_scan_warm_cached_repository_rescan release-candidate 547.3 KiB 32 150.53ms 156.64ms +4.1% stable
clean-training-checkpoint tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_clean_training_checkpoint safe_large 278.2 KiB 1 108.54ms 112.35ms +3.5% stable
mixed-model-repository tests/benchmarks/test_scan_benchmarks.py::test_scan_release_candidate_repository release-candidate 547.3 KiB 32 636.01ms 658.32ms +3.5% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_hex] nested_hex 130 B 1 318.0us 310.0us -2.5% stable
suspicious-pickle-intake tests/benchmarks/test_scan_benchmarks.py::test_scan_suspicious_pickle_intake suspicious-intake 183.8 KiB 4 148.27ms 151.63ms +2.3% stable
padded-multi-stream-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_padded_multi_stream_upload multi_stream_padded 4.1 KiB 1 341.9us 348.0us +1.8% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_raw] nested_raw 78 B 1 278.3us 282.1us +1.4% stable
direct-malicious-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_direct_malicious_upload malicious_reduce 52 B 1 227.0us 223.9us -1.4% stable
duplicate-heavy-registry tests/benchmarks/test_scan_benchmarks.py::test_scan_duplicate_registry_snapshot registry-snapshot 915.2 KiB 13 570.23ms 575.81ms +1.0% stable
rejected-basic-auth-candidates tests/benchmarks/test_scan_benchmarks.py::test_rejected_basic_auth_candidates_scan_linearly - 371.1 KiB 1 2.513s 2.535s +0.9% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_base64] nested_base64 98 B 1 298.4us 295.8us -0.9% stable
single-checkpoint-preflight tests/benchmarks/test_scan_benchmarks.py::test_scan_single_checkpoint_before_load single_checkpoint.pkl 183.0 KiB 1 103.67ms 104.36ms +0.7% stable

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23331802b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modelaudit/__main__.py
Comment thread tests/utils/helpers/test_interrupt_handling.py
Comment thread modelaudit/__main__.py
@mldangelo-oai mldangelo-oai merged commit 839c7cf into main Jul 2, 2026
41 checks passed
@mldangelo-oai mldangelo-oai deleted the fix/cli-startup-interrupt branch July 2, 2026 04:33
@github-actions github-actions Bot mentioned this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants