Skip to content

Conversation

@eluce2
Copy link
Collaborator

@eluce2 eluce2 commented Jan 31, 2026

Fixes #109

Note

Medium Risk
Changes OData query generation for expands by omitting $select when the computed field list is empty, which could subtly alter selection behavior for tables with unusual schemas but primarily prevents server parse errors.

Overview
Fixes expand query generation so $expand clauses no longer emit an empty $select= when a table's defaultSelect: "schema" produces no selectable fields.

getDefaultSelectFields now returns undefined (meaning select all) instead of [] in that case, and ExpandBuilder only includes $select when formatSelectFields yields a non-empty value; adds regression tests for GitHub issue #109 covering simple and nested expands with entity IDs.

Written by Cursor Bugbot for commit 222c01b. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview Jan 31, 2026 7:08pm

Request Review

@eluce2 eluce2 marked this pull request as ready for review January 31, 2026 19:06
Copy link
Collaborator Author

eluce2 commented Jan 31, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 31, 2026

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@110

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@110

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@110

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@110

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@110

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@110

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@110

commit: 222c01b

Copy link
Collaborator Author

eluce2 commented Feb 3, 2026

Merge activity

  • Feb 3, 2:38 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 3, 2:38 AM UTC: @eluce2 merged this pull request with Graphite.

@eluce2 eluce2 merged commit f2db5f2 into main Feb 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fmodata: Nested expand generates empty $select= causing OData parse error

2 participants