test: fix 2 CI flakes (probeCrawler teardown race + intentService timeout)#38
Merged
proofoftrust21 merged 2 commits intomainfrom Apr 24, 2026
Merged
Conversation
Le helper appelait déjà pool.end() avant DROP DATABASE WITH (FORCE),
mais sans listener pool.on('error') les FATAL 57P01 envoyés aux sockets
résiduels (entre fin de pool.end() et fermeture TCP réelle) remontaient
en unhandledRejection et crashaient vitest sur runner CI lent.
Listener silencieux ajouté dans setupTestPool — la fenêtre de race
courte est désormais absorbée proprement.
Le test "limit par défaut 5, clamp à 20" enchaînait 30 await seedEndpoint séquentiels (~1900ms en local). Sur runner CI lent, le plafond 20s pouvait être franchi. Promise.all sur les 30 seeds — chaque endpoint a un hash + URL uniques donc aucune collision, et le temps tombe sous 500ms localement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read-only investigation post PR #37 had identifié 2 flakes intermittents en CI :
probeCrawler.test.ts —
FATAL 57P01 terminating connection due to administrator commandlors du teardown PG. Root cause :pool.end()résout dès que les clients idle ont reçu COM_QUIT, mais le serveur peut encore émettre FATAL 57P01 vers les sockets en cours de fermeture quandDROP DATABASE … WITH (FORCE)les force-termine. Sans listenerpool.on('error'), l'erreur remonte enunhandledRejectionet crash vitest. Classe C (teardown race) + E (CI runner amplifie la fenêtre).intentService.test.ts > limit par défaut 5, clamp à 20 — 30
await seedEndpoint()séquentiels (~1900ms local) frôlaient le plafond 20s sur runner CI lent. Classe A (timing fragile) + E (CI runner).Patches
src/tests/helpers/testDatabase.ts) :pool.on('error', () => {})ajouté danssetupTestPoolpour absorber proprement les 57P01 résiduels lors du teardown. 9 lignes.src/tests/intentService.test.ts) : 30 seeds passés àPromise.all— chaque endpoint a hash + URL uniques, aucune collision. Temps local ~1200ms, ~8.7s sous load full-suite. 12 lignes net.Validation
npm test -- src/tests/probeCrawler.test.ts: 5/5 pass, 1.06snpm test -- src/tests/intentService.test.ts: 12/12 pass, 3.95s ; limit-clamp : 1207ms (était ~1914ms)npm test(suite complète) : 1166 passed, 169 skipped, 0 failures, 77.55sTest plan
setupTestPool/teardownTestPoolOut of scope