Skip to content

Make typegen peers optional#198

Merged
eluce2 merged 1 commit intomainfrom
t3code/optional-typegen-peers
Mar 20, 2026
Merged

Make typegen peers optional#198
eluce2 merged 1 commit intomainfrom
t3code/optional-typegen-peers

Conversation

@eluce2
Copy link
Copy Markdown
Collaborator

@eluce2 eluce2 commented Mar 20, 2026

Summary

  • Move @proofkit/fmodata import in typegen metadata download to a dynamic import.
  • Lets typegen work without the peer present until the code path is used.
  • Add the required changeset for the patch release.

Testing

  • Not run

Summary by CodeRabbit

  • Chores

    • Declared patch release for @proofkit/typegen.
    • Added textlint to development dependencies.
  • Refactor

    • Updated internal module loading mechanism for improved performance.

- lazy-load fmodata in typegen
- add textlint dev dep
- add patch changeset
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview Mar 20, 2026 10:22pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 20, 2026

⚠️ No Changeset found

Latest commit: 0b23627

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 2 packages
Name Type
@proofkit/typegen Patch
@proofkit/cli Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eluce2 eluce2 merged commit 13065aa into main Mar 20, 2026
8 of 10 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ba9829f0-fed9-4391-bf23-d9ae4282da22

📥 Commits

Reviewing files that changed from the base of the PR and between e93ba31 and 0b23627.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .changeset/clean-suns-matter.md
  • package.json
  • packages/typegen/src/fmodata/downloadMetadata.ts

📝 Walkthrough

Walkthrough

A patch release for @proofkit/typegen is being prepared. The changes include adding textlint to development dependencies and converting a static import of FMServerConnection to a dynamic import within the metadata download module.

Changes

Cohort / File(s) Summary
Release Metadata
.changeset/clean-suns-matter.md
Declares a patch version bump for @proofkit/typegen.
Development Tooling
package.json
Added textlint ^15.5.2 as a dev dependency.
Import Refactoring
packages/typegen/src/fmodata/downloadMetadata.ts
Converted static import of FMServerConnection to dynamic import using await import(), executed after environment validation and MCP-mode checks within downloadTableMetadata function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • chriscors
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/optional-typegen-peers

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant