Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6a98233 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
📝 WalkthroughWalkthroughMigrates documentation and asset domain references from proofkit.dev to proofkit.proof.sh across docs, package metadata, CLI constants, templates, localization strings, typegen schema refs, generated headers, and one new CLI audit doc. No runtime logic or public API signatures were meaningfully changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (8)
apps/docs/src/lib/get-llm-text.ts (1)
31-33: Centralize the docs origin to avoid future drift.Line 32 hardcodes the docs origin inline. Consider extracting it to a single constant (or shared config) so future domain updates don’t require touching multiple files.
💡 Suggested refactor
+const DOCS_ORIGIN = "https://proofkit.proof.sh"; export async function getLLMText(page: InferPageType<typeof source>): Promise<string> { @@ return `# ${page.data.title} -URL: https://proofkit.proof.sh${page.url} +URL: ${DOCS_ORIGIN}${page.url}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/docs/src/lib/get-llm-text.ts` around lines 31 - 33, The template in get-llm-text.ts hardcodes the docs origin ("https://proofkit.proof.sh"); extract that value into a single constant (e.g., DOCS_ORIGIN) or import a shared config value and use it in the returned template (the string that currently uses page.url), replacing the inline literal so all references use DOCS_ORIGIN; update the return template to reference DOCS_ORIGIN when building the URL and add an exported/centralized constant or import so future domain changes only require updating one place.packages/cli/src/installers/nextAuth.ts (1)
186-188: Avoid hardcoding the docs base URL in installer output.Use the existing
DOCS_URLconstant (packages/cli/src/consts.ts) so future domain changes only require one update.♻️ Suggested refactor
-import { PKG_ROOT } from "~/consts.js"; +import { DOCS_URL, PKG_ROOT } from "~/consts.js"; @@ console.log( `${chalk.yellowBright("You must now install the NextAuth addon in your FileMaker file.")} -Learn more: https://proofkit.proof.sh/auth/next-auth\n`, +Learn more: ${DOCS_URL}/auth/next-auth\n`, );As per coding guidelines, "Use meaningful variable names instead of magic numbers - extract constants with descriptive names".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/installers/nextAuth.ts` around lines 186 - 188, Replace the hardcoded docs URL in the NextAuth installer output with the shared DOCS_URL constant: import DOCS_URL from the existing consts module (packages/cli/src/consts.ts) and use it in the template string inside the function that prints the message (the string currently containing "https://proofkit.proof.sh/auth/next-auth\n"). Update the message construction in the NextAuth installer (nextAuth.ts) to reference DOCS_URL so future domain changes are centralized.apps/docs/src/app/sitemap.ts (1)
4-4: Consider centralizing the docs base URL constant.Line [4] is correct, but the same domain is duplicated in
apps/docs/src/app/robots.tsandapps/docs/src/app/layout.tsx. A shared constant would reduce drift in future domain changes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/docs/src/app/sitemap.ts` at line 4, The BASE_URL string is duplicated across BASE_URL in sitemap.ts and also used in robots.ts and layout.tsx; create a single exported constant (e.g., export const DOCS_BASE_URL) in a shared module (e.g., apps/docs/src/constants or config) and replace the inline string usages in sitemap.ts (BASE_URL), robots.ts, and layout.tsx to import and use that constant so future domain changes are made in one place.packages/typegen/src/server/api.ts (1)
115-115: Centralize the typegen schema URL constant.Line [115] is correct, but this URL should live in one shared constant (used by both API and app config writers) to avoid future divergence.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/typegen/src/server/api.ts` at line 115, Centralize the hardcoded schema URL by extracting the string used for the "$schema" key into a single exported constant (e.g., TYPEGEN_SCHEMA_URL) in a shared module (like a new/typegen constants file) and replace the inline string in the API writer (the location that currently sets $schema: "https://proofkit.proof.sh/typegen-config-schema.json") with an import of that constant; also update the app config writer to import and use the same constant so both writers reference the single source of truth.packages/cli/src/installers/install-fm-addon.ts (1)
219-219: Deduplicate add-on docs URLs to one source of truth.The same docs URLs are repeated in multiple places. A small
Record<FmAddonName, string>constant would avoid future mismatches.♻️ Suggested refactor
+const ADDON_DOCS_URL: Record<FmAddonName, string> = { + auth: "https://proofkit.proof.sh/auth/fm-addon", + wv: "https://proofkit.proof.sh/webviewer", +}; export function getFmAddonInstallInstructions(addonName: FmAddonName) { @@ - docsUrl: addonName === "auth" ? "https://proofkit.proof.sh/auth/fm-addon" : "https://proofkit.proof.sh/webviewer", + docsUrl: ADDON_DOCS_URL[addonName], @@ - )} ${chalk.dim("(Learn more: https://proofkit.proof.sh/auth/fm-addon)")}`, + )} ${chalk.dim(`(Learn more: ${ADDON_DOCS_URL.auth})`)}`, @@ - )} ${chalk.dim("(Learn more: https://proofkit.proof.sh/webviewer)")}`, + )} ${chalk.dim(`(Learn more: ${ADDON_DOCS_URL.wv})`)}`,Also applies to: 251-257
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/installers/install-fm-addon.ts` at line 219, Create a single source-of-truth mapping for add-on docs by defining a constant Record<FmAddonName, string> (e.g., ADDON_DOCS_URLS) and use it wherever docsUrl is set; replace the inline ternary at docsUrl (currently using addonName === "auth" ? ...) and the other repeated blocks (lines around 251-257) to reference ADDON_DOCS_URLS[addonName]; ensure the mapping keys match the FmAddonName union and import or declare FmAddonName where needed so all references (docsUrl, addonName, any helper functions in install-fm-addon.ts) use the central constant.packages/cli-old/src/installers/install-fm-addon.ts (2)
42-42: Refactor to use DOCS_URL constant instead of hardcoding.Same issue as line 36—the URL should use the
DOCS_URLconstant from~/consts.js.♻️ Proposed refactor
`${chalk.yellowBright( "You must install the ProofKit WebViewer addon in your FileMaker file to continue.", - )} ${chalk.dim("(Learn more: https://proofkit.proof.sh/webviewer)")}`, + )} ${chalk.dim(`(Learn more: ${DOCS_URL}/webviewer)`)}`,As per coding guidelines: "Use meaningful variable names instead of magic numbers - extract constants with descriptive names."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli-old/src/installers/install-fm-addon.ts` at line 42, Replace the hardcoded "https://proofkit.proof.sh/webviewer" URL in the template literal inside install-fm-addon.ts with the DOCS_URL constant from ~/consts.js: import DOCS_URL and use it to build the path (e.g., `${DOCS_URL}/webviewer`) where the current string has "(Learn more: https://proofkit.proof.sh/webviewer)"; update the template literal and add the import for DOCS_URL so the message uses the constant instead of a magic string.
36-36: Refactor to use DOCS_URL constant instead of hardcoding.The URL is hardcoded when a
DOCS_URLconstant is already exported from~/consts.js. Using the constant improves maintainability and follows DRY principles.♻️ Proposed refactor
Import the constant at the top of the file:
import { PKG_ROOT } from "~/consts.js"; +import { DOCS_URL } from "~/consts.js"; import { logger } from "~/utils/logger.js";Then use it in the message:
`${chalk.yellowBright( "You must install the FM Auth addon in your FileMaker file to continue.", - )} ${chalk.dim("(Learn more: https://proofkit.proof.sh/auth/fm-addon)")}`, + )} ${chalk.dim(`(Learn more: ${DOCS_URL}/auth/fm-addon)`)}`,As per coding guidelines: "Use meaningful variable names instead of magic numbers - extract constants with descriptive names."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli-old/src/installers/install-fm-addon.ts` at line 36, Replace the hardcoded docs link in install-fm-addon.ts with the exported DOCS_URL constant: add an import for DOCS_URL from '~/consts.js' at the top of the file, then update the template string that currently contains "(Learn more: https://proofkit.proof.sh/auth/fm-addon)" to use DOCS_URL (e.g., interpolate or concatenate DOCS_URL with "/auth/fm-addon") so the message uses DOCS_URL instead of the literal URL.packages/cli/src/generators/fmdapi.ts (1)
75-76: Extract the schema URL into a shared constant.The same schema string is repeated in multiple places, which makes future domain/schema updates easy to miss.
♻️ Proposed refactor
interface FullProofkitTypegenJsonFile { $schema?: string; config: AnyDataSourceConfig | AnyDataSourceConfig[]; } const typegenConfigFileName = "proofkit-typegen.config.jsonc"; +const TYPEGEN_CONFIG_SCHEMA_URL = "https://proofkit.proof.sh/typegen-config-schema.json" as const; ... return { - $schema: "https://proofkit.proof.sh/typegen-config-schema.json", + $schema: TYPEGEN_CONFIG_SCHEMA_URL, config: [], }; ... fileContent = { - $schema: "https://proofkit.proof.sh/typegen-config-schema.json", + $schema: TYPEGEN_CONFIG_SCHEMA_URL, config: [], }; ... fileContent = { - $schema: "https://proofkit.proof.sh/typegen-config-schema.json", + $schema: TYPEGEN_CONFIG_SCHEMA_URL, config: configsToAdd, }; ... fileContent = { - $schema: "https://proofkit.proof.sh/typegen-config-schema.json", + $schema: TYPEGEN_CONFIG_SCHEMA_URL, config: [newConfig], }; ... fileContent = { - $schema: "https://proofkit.proof.sh/typegen-config-schema.json", + $schema: TYPEGEN_CONFIG_SCHEMA_URL, config: [newDataSource], };As per coding guidelines,
**/*.{js,jsx,ts,tsx}: Use meaningful variable names instead of magic numbers - extract constants with descriptive names.Also applies to: 117-118, 192-193, 235-236, 405-406
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/generators/fmdapi.ts` around lines 75 - 76, Replace the repeated literal "https://proofkit.proof.sh/typegen-config-schema.json" with a single descriptive constant (e.g. TYPEGEN_CONFIG_SCHEMA_URL) and use that constant wherever the $schema string is currently inlined (including the occurrences referenced around lines 75-76, 117-118, 192-193, 235-236, 405-406); define and export the constant from a shared location (or from the top of this module if intended for local reuse) and update the object literals that currently set $schema to the raw string to instead reference TYPEGEN_CONFIG_SCHEMA_URL so future updates require changing one symbol only.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Auto` Run
Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-02.md:
- Around line 30-33: The instruction is ambiguous about whether SKILL.md
`sources` should be repository path references or public doc URLs; update
RELEASE-READINESS-02.md to state a single canonical expectation (either
repo-style references like "proofsh/proofkit:packages/typegen/src/cli.ts" or
full proofkit.proof.sh URLs), then update examples and guidance accordingly:
reference the SKILL.md `sources` frontmatter (e.g.,
packages/fmdapi/skills/typegen-fmdapi/SKILL.md) to show the preferred format,
add a note for maintainers on how to convert repo paths to public URLs (or vice
versa), and ensure the cross-linking checklist items for
apps/docs/content/docs/{package}/index.mdx and CLI help text in
packages/cli/src/ reflect that chosen format.
In `@packages/cli-old/template/extras/emailTemplates/generic.tsx`:
- Line 19: Update the broken logo URL used in the email template by replacing
the hardcoded src value
"https://proofkit.proof.sh/_astro/proofkit.DNcFg0_B_1JN3Dz.webp" with the
correct asset path on the new domain in the generic email template; locate both
occurrences referenced in the file (the img src at the top and the duplicate at
the bottom around the CTA) and update them to the verified working CDN/hosted
URL so the logo no longer 404s while leaving the CTA href
("https://proofkit.proof.sh") unchanged.
In `@packages/cli-old/template/nextjs-mantine/src/app/`(main)/page.tsx:
- Around line 45-47: The external anchor element with href
"https://proofkit.proof.sh" uses target="_blank" but its rel attribute
("proofkit-app") does not include "noopener"; update the anchor (the link
element in page.tsx that sets href="https://proofkit.proof.sh" and
target="_blank") to include "noopener" in the rel value (e.g., add or append
noopener to the existing rel string) so the link uses rel="noopener" (or
"proofkit-app noopener") to prevent the opened page from accessing
window.opener.
In `@packages/cli/template/extras/emailTemplates/auth-code.tsx`:
- Line 17: The auth-code email template (auth-code.tsx) is using an unstable
Astro build artifact URL
("https://proofkit.proof.sh/_astro/proofkit.DNcFg0_B_1JN3Dz.webp"); update the
image src in that template to the stable path used by registry templates
("https://proofkit.proof.sh/proofkit.png") so email templates don’t break after
site rebuilds—locate the src attribute in
packages/cli/template/extras/emailTemplates/auth-code.tsx and replace the hashed
_astro URL with /proofkit.png.
In `@packages/cli/template/extras/emailTemplates/generic.tsx`:
- Line 19: The logo image URL in generic.tsx (the <img
src="...proofkit.DNcFg0_B_1JN3Dz.webp"> occurrences) is 404; locate the two
img/logo usages in packages/cli/template/extras/emailTemplates/generic.tsx (the
logo image tags around the header and footer) and either update their src
attributes to a valid, deployed URL on proofkit.proof.sh or replace them with
the correct relative/CDN path for the deployed asset; alternatively ensure the
missing asset is uploaded to the new domain so the existing src resolves
successfully.
In `@packages/cli/template/extras/fmaddon-auth/emails/auth-code.tsx`:
- Line 17: The img src in the email template (auth-code.tsx) is pointing to a
broken URL "https://proofkit.proof.sh/_astro/proofkit.DNcFg0_B_1JN3Dz.webp"
which 404s; update the src value to a reachable logo asset (e.g., the project's
public/static logo or a stable CDN URL) so the <img> in auth-code.tsx loads
correctly, ensuring the new URL is absolute and accessible from email clients.
In `@packages/cli/template/nextjs-shadcn/src/app/`(main)/page.tsx:
- Line 81: The external anchor tag <a href="https://proofkit.proof.sh"
rel="noreferrer" target="_blank"> should include rel="noopener" as well to
prevent the opened page from accessing the window.opener; update the anchor in
page.tsx (the anchor element linking to https://proofkit.proof.sh) to add
"noopener" to its rel attribute (e.g., rel="noreferrer noopener").
---
Nitpick comments:
In `@apps/docs/src/app/sitemap.ts`:
- Line 4: The BASE_URL string is duplicated across BASE_URL in sitemap.ts and
also used in robots.ts and layout.tsx; create a single exported constant (e.g.,
export const DOCS_BASE_URL) in a shared module (e.g., apps/docs/src/constants or
config) and replace the inline string usages in sitemap.ts (BASE_URL),
robots.ts, and layout.tsx to import and use that constant so future domain
changes are made in one place.
In `@apps/docs/src/lib/get-llm-text.ts`:
- Around line 31-33: The template in get-llm-text.ts hardcodes the docs origin
("https://proofkit.proof.sh"); extract that value into a single constant (e.g.,
DOCS_ORIGIN) or import a shared config value and use it in the returned template
(the string that currently uses page.url), replacing the inline literal so all
references use DOCS_ORIGIN; update the return template to reference DOCS_ORIGIN
when building the URL and add an exported/centralized constant or import so
future domain changes only require updating one place.
In `@packages/cli-old/src/installers/install-fm-addon.ts`:
- Line 42: Replace the hardcoded "https://proofkit.proof.sh/webviewer" URL in
the template literal inside install-fm-addon.ts with the DOCS_URL constant from
~/consts.js: import DOCS_URL and use it to build the path (e.g.,
`${DOCS_URL}/webviewer`) where the current string has "(Learn more:
https://proofkit.proof.sh/webviewer)"; update the template literal and add the
import for DOCS_URL so the message uses the constant instead of a magic string.
- Line 36: Replace the hardcoded docs link in install-fm-addon.ts with the
exported DOCS_URL constant: add an import for DOCS_URL from '~/consts.js' at the
top of the file, then update the template string that currently contains "(Learn
more: https://proofkit.proof.sh/auth/fm-addon)" to use DOCS_URL (e.g.,
interpolate or concatenate DOCS_URL with "/auth/fm-addon") so the message uses
DOCS_URL instead of the literal URL.
In `@packages/cli/src/generators/fmdapi.ts`:
- Around line 75-76: Replace the repeated literal
"https://proofkit.proof.sh/typegen-config-schema.json" with a single descriptive
constant (e.g. TYPEGEN_CONFIG_SCHEMA_URL) and use that constant wherever the
$schema string is currently inlined (including the occurrences referenced around
lines 75-76, 117-118, 192-193, 235-236, 405-406); define and export the constant
from a shared location (or from the top of this module if intended for local
reuse) and update the object literals that currently set $schema to the raw
string to instead reference TYPEGEN_CONFIG_SCHEMA_URL so future updates require
changing one symbol only.
In `@packages/cli/src/installers/install-fm-addon.ts`:
- Line 219: Create a single source-of-truth mapping for add-on docs by defining
a constant Record<FmAddonName, string> (e.g., ADDON_DOCS_URLS) and use it
wherever docsUrl is set; replace the inline ternary at docsUrl (currently using
addonName === "auth" ? ...) and the other repeated blocks (lines around 251-257)
to reference ADDON_DOCS_URLS[addonName]; ensure the mapping keys match the
FmAddonName union and import or declare FmAddonName where needed so all
references (docsUrl, addonName, any helper functions in install-fm-addon.ts) use
the central constant.
In `@packages/cli/src/installers/nextAuth.ts`:
- Around line 186-188: Replace the hardcoded docs URL in the NextAuth installer
output with the shared DOCS_URL constant: import DOCS_URL from the existing
consts module (packages/cli/src/consts.ts) and use it in the template string
inside the function that prints the message (the string currently containing
"https://proofkit.proof.sh/auth/next-auth\n"). Update the message construction
in the NextAuth installer (nextAuth.ts) to reference DOCS_URL so future domain
changes are centralized.
In `@packages/typegen/src/server/api.ts`:
- Line 115: Centralize the hardcoded schema URL by extracting the string used
for the "$schema" key into a single exported constant (e.g., TYPEGEN_SCHEMA_URL)
in a shared module (like a new/typegen constants file) and replace the inline
string in the API writer (the location that currently sets $schema:
"https://proofkit.proof.sh/typegen-config-schema.json") with an import of that
constant; also update the app config writer to import and use the same constant
so both writers reference the single source of truth.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1fb06d2e-6a5d-4470-a89e-daec9736dc7f
📒 Files selected for processing (115)
.changeset/brown-owls-bake.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-01.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-02.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-03.mdREADME.mdapps/docs/content/docs/fmdapi/quick-start.mdxapps/docs/content/docs/typegen/config-odata.mdxapps/docs/content/docs/typegen/config.mdxapps/docs/src/app/docs/(docs)/[[...slug]]/page.tsxapps/docs/src/app/layout.tsxapps/docs/src/app/llms.txt/route.tsapps/docs/src/app/robots.tsapps/docs/src/app/sitemap.tsapps/docs/src/lib/get-llm-text.tspackages/better-auth/README.mdpackages/better-auth/package.jsonpackages/cli-old/README.mdpackages/cli-old/src/cli/add/data-source/deploy-demo-file.tspackages/cli-old/src/consts.tspackages/cli-old/src/generators/fmdapi.tspackages/cli-old/src/installers/install-fm-addon.tspackages/cli-old/src/installers/nextAuth.tspackages/cli-old/template/extras/emailProviders/none/email.tsxpackages/cli-old/template/extras/emailTemplates/auth-code.tsxpackages/cli-old/template/extras/emailTemplates/generic.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/login/login-form.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsxpackages/cli-old/template/extras/fmaddon-auth/emails/auth-code.tsxpackages/cli-old/template/fm-addon/ProofKitAuth/de.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/en.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/es.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/fr.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/info.jsonpackages/cli-old/template/fm-addon/ProofKitAuth/it.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/ja.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/ko.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/nl.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/pt.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/sv.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/template.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/zh.xmlpackages/cli-old/template/fm-addon/ProofKitWV/info.jsonpackages/cli-old/template/nextjs-mantine/README.mdpackages/cli-old/template/nextjs-mantine/src/app/(main)/page.tsxpackages/cli-old/template/nextjs-shadcn/README.mdpackages/cli-old/template/nextjs-shadcn/src/app/(main)/page.tsxpackages/cli-old/template/vite-wv/proofkit-typegen.config.jsoncpackages/cli-old/tsdown.config.tspackages/cli/README.mdpackages/cli/src/cli/add/data-source/deploy-demo-file.tspackages/cli/src/consts.tspackages/cli/src/generators/fmdapi.tspackages/cli/src/installers/install-fm-addon.tspackages/cli/src/installers/nextAuth.tspackages/cli/src/services/live.tspackages/cli/src/utils/projectFiles.tspackages/cli/template/extras/emailProviders/none/email.tsxpackages/cli/template/extras/emailTemplates/auth-code.tsxpackages/cli/template/extras/emailTemplates/generic.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/login/login-form.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsxpackages/cli/template/extras/fmaddon-auth/emails/auth-code.tsxpackages/cli/template/fm-addon/ProofKitAuth/de.xmlpackages/cli/template/fm-addon/ProofKitAuth/en.xmlpackages/cli/template/fm-addon/ProofKitAuth/es.xmlpackages/cli/template/fm-addon/ProofKitAuth/fr.xmlpackages/cli/template/fm-addon/ProofKitAuth/info.jsonpackages/cli/template/fm-addon/ProofKitAuth/it.xmlpackages/cli/template/fm-addon/ProofKitAuth/ja.xmlpackages/cli/template/fm-addon/ProofKitAuth/ko.xmlpackages/cli/template/fm-addon/ProofKitAuth/nl.xmlpackages/cli/template/fm-addon/ProofKitAuth/pt.xmlpackages/cli/template/fm-addon/ProofKitAuth/sv.xmlpackages/cli/template/fm-addon/ProofKitAuth/template.xmlpackages/cli/template/fm-addon/ProofKitAuth/zh.xmlpackages/cli/template/fm-addon/ProofKitWV/info.jsonpackages/cli/template/fm-addon/ProofKitWV/records_de.xmlpackages/cli/template/fm-addon/ProofKitWV/records_en.xmlpackages/cli/template/fm-addon/ProofKitWV/records_es.xmlpackages/cli/template/fm-addon/ProofKitWV/records_fr.xmlpackages/cli/template/fm-addon/ProofKitWV/records_it.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ja.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ko.xmlpackages/cli/template/fm-addon/ProofKitWV/records_nl.xmlpackages/cli/template/fm-addon/ProofKitWV/records_pt.xmlpackages/cli/template/fm-addon/ProofKitWV/records_sv.xmlpackages/cli/template/fm-addon/ProofKitWV/records_zh.xmlpackages/cli/template/nextjs-shadcn/README.mdpackages/cli/template/nextjs-shadcn/src/app/(main)/page.tsxpackages/cli/template/vite-wv/proofkit-typegen.config.jsoncpackages/create-proofkit/README.mdpackages/fmdapi/README.mdpackages/fmdapi/skills/typegen-fmdapi/SKILL.mdpackages/fmodata/README.mdpackages/fmodata/skills/typegen-fmodata/SKILL.mdpackages/registry/templates/better-auth/auth.hbspackages/registry/templates/email/auth-code/auth-code.tsxpackages/registry/templates/email/generic/generic.tsxpackages/registry/templates/fmdapi/proofkit-typegen.config.jsoncpackages/registry/templates/table/basic/README.hbspackages/typegen/README.mdpackages/typegen/live-fm-mcp-output/client/contacts.tspackages/typegen/package.jsonpackages/typegen/proofkit-typegen.config.jsoncpackages/typegen/proofkit-typegen.fm-mcp.local.jsoncpackages/typegen/src/constants.tspackages/typegen/src/server/api.tspackages/typegen/src/server/app.tspackages/typegen/stubs/proofkit-typegen.config.jsoncpackages/typegen/tests/__snapshots__/strict-numbers.snap.tspackages/typegen/tests/__snapshots__/zod-layout-client.snap.tspackages/webviewer/README.mdpackages/webviewer/package.json
Comment on lines
30
to
+33
| - [ ] Improve cross-linking between docs, skills, and CLI output: | ||
| - In each package's main doc page (`apps/docs/content/docs/{package}/index.mdx`), add a "For AI Agents" callout or section at the bottom that points to the package's SKILL.md file location and the llms.txt per-package endpoint. Use a Fumadocs `Callout` component if available, or a simple blockquote. | ||
| - In each SKILL.md file's `sources` frontmatter field, verify the doc URLs point to the correct pages on proofkit.dev. Update any that are wrong or missing. | ||
| - In the CLI's help output (check `packages/cli/src/` for the main command definitions), ensure the `--help` text mentions `https://proofkit.dev/docs/cli` for full documentation. | ||
| - In each SKILL.md file's `sources` frontmatter field, verify the doc URLs point to the correct pages on proofkit.proof.sh. Update any that are wrong or missing. | ||
| - In the CLI's help output (check `packages/cli/src/` for the main command definitions), ensure the `--help` text mentions `https://proofkit.proof.sh/docs/cli` for full documentation. |
There was a problem hiding this comment.
Clarify SKILL.md sources format expectation.
Line 32 instructs verifying that SKILL.md sources frontmatter URLs "point to the correct pages on proofkit.proof.sh." However, the actual SKILL.md files (e.g., packages/fmdapi/skills/typegen-fmdapi/SKILL.md) use repository path references like "proofsh/proofkit:packages/typegen/src/cli.ts" rather than direct proofkit.proof.sh URLs. This task requirement may need clarification about whether sources should contain repo paths or documentation URLs.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Auto` Run
Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-02.md
around lines 30 - 33, The instruction is ambiguous about whether SKILL.md
`sources` should be repository path references or public doc URLs; update
RELEASE-READINESS-02.md to state a single canonical expectation (either
repo-style references like "proofsh/proofkit:packages/typegen/src/cli.ts" or
full proofkit.proof.sh URLs), then update examples and guidance accordingly:
reference the SKILL.md `sources` frontmatter (e.g.,
packages/fmdapi/skills/typegen-fmdapi/SKILL.md) to show the preferred format,
add a note for maintainers on how to convert repo paths to public URLs (or vice
versa), and ensure the cross-linking checklist items for
apps/docs/content/docs/{package}/index.mdx and CLI help text in
packages/cli/src/ reflect that chosen format.
Comment on lines
+45
to
47
| href="https://proofkit.proof.sh" | ||
| target="_blank" | ||
| rel="proofkit-app" |
There was a problem hiding this comment.
Add noopener for the external docs link opened in a new tab.
On Line 47, rel is missing noopener while using target="_blank" (Line 46).
Suggested fix
- rel="proofkit-app"
+ rel="proofkit-app noopener noreferrer"As per coding guidelines, "Add rel="noopener" when using target="_blank" on links".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli-old/template/nextjs-mantine/src/app/`(main)/page.tsx around
lines 45 - 47, The external anchor element with href "https://proofkit.proof.sh"
uses target="_blank" but its rel attribute ("proofkit-app") does not include
"noopener"; update the anchor (the link element in page.tsx that sets
href="https://proofkit.proof.sh" and target="_blank") to include "noopener" in
the rel value (e.g., add or append noopener to the existing rel string) so the
link uses rel="noopener" (or "proofkit-app noopener") to prevent the opened page
from accessing window.opener.
| <div> | ||
| <Button asChild variant="outline"> | ||
| <a href="https://proofkit.dev" rel="noreferrer" target="_blank"> | ||
| <a href="https://proofkit.proof.sh" rel="noreferrer" target="_blank"> |
There was a problem hiding this comment.
Add noopener to the external docs link rel attribute.
Please include noopener explicitly when using target="_blank".
Suggested fix
- <a href="https://proofkit.proof.sh" rel="noreferrer" target="_blank">
+ <a href="https://proofkit.proof.sh" rel="noopener noreferrer" target="_blank">As per coding guidelines, "Don't use target="_blank" without rel="noopener"".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <a href="https://proofkit.proof.sh" rel="noreferrer" target="_blank"> | |
| <a href="https://proofkit.proof.sh" rel="noopener noreferrer" target="_blank"> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/template/nextjs-shadcn/src/app/`(main)/page.tsx at line 81, The
external anchor tag <a href="https://proofkit.proof.sh" rel="noreferrer"
target="_blank"> should include rel="noopener" as well to prevent the opened
page from accessing the window.opener; update the anchor in page.tsx (the anchor
element linking to https://proofkit.proof.sh) to add "noopener" to its rel
attribute (e.g., rel="noreferrer noopener").
- update docs, CLI, templates, and metadata links - add changeset for published packages
- Document current ProofKit CLI runtime flow - Call out stranded legacy branches and dead ends - Note root docs/runtime surface drift
eluce2
force-pushed
the
feature/docs-proofsh-domain
branch
from
90521d3 to
6a98233
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/cli/src/consts.ts (1)
14-17: Derive the docs link fromDOCS_URLto prevent drift.Line 15 duplicates the domain as a hardcoded literal instead of reusing Line 12, so future domain edits can silently diverge.
As per coding guidelines, "Use meaningful variable names instead of magic numbers - extract constants with descriptive names."♻️ Proposed refactor
export const AGENT_INSTRUCTIONS = [ - "Use the ProofKit docs as the primary reference for this project: https://proofkit.proof.sh/docs", + `Use the ProofKit docs as the primary reference for this project: ${DOCS_URL}/docs`, "Before doing any AI-assisted development here, run `npx `@tanstack/intent`@latest install` in the project root to load skills relevant to this project", ].join("\n");🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/src/consts.ts` around lines 14 - 17, AGENT_INSTRUCTIONS currently hardcodes the docs URL; update it to derive the link from the existing DOCS_URL constant so the domain isn't duplicated. Replace the literal "https://proofkit.proof.sh/docs" inside AGENT_INSTRUCTIONS with a template or string concatenation that uses DOCS_URL (e.g., `${DOCS_URL}/docs`) so future changes to DOCS_URL automatically propagate; modify the AGENT_INSTRUCTIONS declaration to reference DOCS_URL accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cli/src/consts.ts`:
- Around line 19-22: The build never replaces the compile-time constant
__REGISTRY_URL__, so DEFAULT_REGISTRY_URL in packages/cli/src/consts.ts always
falls back to the production URL; fix packages/cli/tsdown.config.ts by restoring
the replace plugin configuration to inject __REGISTRY_URL__ (use replace({
__REGISTRY_URL__: JSON.stringify(isDev ? "http://localhost:3005" :
"https://proofkit.proof.sh") })) so the runtime check in DEFAULT_REGISTRY_URL
works as intended.
---
Nitpick comments:
In `@packages/cli/src/consts.ts`:
- Around line 14-17: AGENT_INSTRUCTIONS currently hardcodes the docs URL; update
it to derive the link from the existing DOCS_URL constant so the domain isn't
duplicated. Replace the literal "https://proofkit.proof.sh/docs" inside
AGENT_INSTRUCTIONS with a template or string concatenation that uses DOCS_URL
(e.g., `${DOCS_URL}/docs`) so future changes to DOCS_URL automatically
propagate; modify the AGENT_INSTRUCTIONS declaration to reference DOCS_URL
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba88e7c9-f809-47b6-9b48-412adc1609c1
📒 Files selected for processing (116)
.changeset/brown-owls-bake.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-01.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-02.mdAuto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-03.mdREADME.mdapps/docs/content/docs/fmdapi/quick-start.mdxapps/docs/content/docs/typegen/config-odata.mdxapps/docs/content/docs/typegen/config.mdxapps/docs/src/app/docs/(docs)/[[...slug]]/page.tsxapps/docs/src/app/layout.tsxapps/docs/src/app/llms.txt/route.tsapps/docs/src/app/robots.tsapps/docs/src/app/sitemap.tsapps/docs/src/lib/get-llm-text.tspackages/better-auth/README.mdpackages/better-auth/package.jsonpackages/cli-old/README.mdpackages/cli-old/src/cli/add/data-source/deploy-demo-file.tspackages/cli-old/src/consts.tspackages/cli-old/src/generators/fmdapi.tspackages/cli-old/src/installers/install-fm-addon.tspackages/cli-old/src/installers/nextAuth.tspackages/cli-old/template/extras/emailProviders/none/email.tsxpackages/cli-old/template/extras/emailTemplates/auth-code.tsxpackages/cli-old/template/extras/emailTemplates/generic.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/login/login-form.tsxpackages/cli-old/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsxpackages/cli-old/template/extras/fmaddon-auth/emails/auth-code.tsxpackages/cli-old/template/fm-addon/ProofKitAuth/de.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/en.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/es.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/fr.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/info.jsonpackages/cli-old/template/fm-addon/ProofKitAuth/it.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/ja.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/ko.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/nl.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/pt.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/sv.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/template.xmlpackages/cli-old/template/fm-addon/ProofKitAuth/zh.xmlpackages/cli-old/template/fm-addon/ProofKitWV/info.jsonpackages/cli-old/template/nextjs-mantine/README.mdpackages/cli-old/template/nextjs-mantine/src/app/(main)/page.tsxpackages/cli-old/template/nextjs-shadcn/README.mdpackages/cli-old/template/nextjs-shadcn/src/app/(main)/page.tsxpackages/cli-old/template/vite-wv/proofkit-typegen.config.jsoncpackages/cli-old/tsdown.config.tspackages/cli/CLI_FLOW_AUDIT.mdpackages/cli/README.mdpackages/cli/src/cli/add/data-source/deploy-demo-file.tspackages/cli/src/consts.tspackages/cli/src/generators/fmdapi.tspackages/cli/src/installers/install-fm-addon.tspackages/cli/src/installers/nextAuth.tspackages/cli/src/services/live.tspackages/cli/src/utils/projectFiles.tspackages/cli/template/extras/emailProviders/none/email.tsxpackages/cli/template/extras/emailTemplates/auth-code.tsxpackages/cli/template/extras/emailTemplates/generic.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/login/login-form.tsxpackages/cli/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsxpackages/cli/template/extras/fmaddon-auth/emails/auth-code.tsxpackages/cli/template/fm-addon/ProofKitAuth/de.xmlpackages/cli/template/fm-addon/ProofKitAuth/en.xmlpackages/cli/template/fm-addon/ProofKitAuth/es.xmlpackages/cli/template/fm-addon/ProofKitAuth/fr.xmlpackages/cli/template/fm-addon/ProofKitAuth/info.jsonpackages/cli/template/fm-addon/ProofKitAuth/it.xmlpackages/cli/template/fm-addon/ProofKitAuth/ja.xmlpackages/cli/template/fm-addon/ProofKitAuth/ko.xmlpackages/cli/template/fm-addon/ProofKitAuth/nl.xmlpackages/cli/template/fm-addon/ProofKitAuth/pt.xmlpackages/cli/template/fm-addon/ProofKitAuth/sv.xmlpackages/cli/template/fm-addon/ProofKitAuth/template.xmlpackages/cli/template/fm-addon/ProofKitAuth/zh.xmlpackages/cli/template/fm-addon/ProofKitWV/info.jsonpackages/cli/template/fm-addon/ProofKitWV/records_de.xmlpackages/cli/template/fm-addon/ProofKitWV/records_en.xmlpackages/cli/template/fm-addon/ProofKitWV/records_es.xmlpackages/cli/template/fm-addon/ProofKitWV/records_fr.xmlpackages/cli/template/fm-addon/ProofKitWV/records_it.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ja.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ko.xmlpackages/cli/template/fm-addon/ProofKitWV/records_nl.xmlpackages/cli/template/fm-addon/ProofKitWV/records_pt.xmlpackages/cli/template/fm-addon/ProofKitWV/records_sv.xmlpackages/cli/template/fm-addon/ProofKitWV/records_zh.xmlpackages/cli/template/nextjs-shadcn/README.mdpackages/cli/template/nextjs-shadcn/src/app/(main)/page.tsxpackages/cli/template/vite-wv/proofkit-typegen.config.jsoncpackages/create-proofkit/README.mdpackages/fmdapi/README.mdpackages/fmdapi/skills/typegen-fmdapi/SKILL.mdpackages/fmodata/README.mdpackages/fmodata/skills/typegen-fmodata/SKILL.mdpackages/registry/templates/better-auth/auth.hbspackages/registry/templates/email/auth-code/auth-code.tsxpackages/registry/templates/email/generic/generic.tsxpackages/registry/templates/fmdapi/proofkit-typegen.config.jsoncpackages/registry/templates/table/basic/README.hbspackages/typegen/README.mdpackages/typegen/live-fm-mcp-output/client/contacts.tspackages/typegen/package.jsonpackages/typegen/proofkit-typegen.config.jsoncpackages/typegen/proofkit-typegen.fm-mcp.local.jsoncpackages/typegen/src/constants.tspackages/typegen/src/server/api.tspackages/typegen/src/server/app.tspackages/typegen/stubs/proofkit-typegen.config.jsoncpackages/typegen/tests/__snapshots__/strict-numbers.snap.tspackages/typegen/tests/__snapshots__/zod-layout-client.snap.tspackages/webviewer/README.mdpackages/webviewer/package.json
✅ Files skipped from review due to trivial changes (98)
- packages/registry/templates/fmdapi/proofkit-typegen.config.jsonc
- packages/cli-old/README.md
- packages/typegen/README.md
- packages/registry/templates/email/auth-code/auth-code.tsx
- packages/create-proofkit/README.md
- packages/fmodata/README.md
- packages/better-auth/README.md
- apps/docs/src/app/sitemap.ts
- packages/typegen/package.json
- packages/typegen/live-fm-mcp-output/client/contacts.ts
- packages/fmdapi/README.md
- packages/cli/template/vite-wv/proofkit-typegen.config.jsonc
- packages/cli/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsx
- packages/webviewer/README.md
- packages/typegen/tests/snapshots/strict-numbers.snap.ts
- packages/cli/README.md
- packages/cli-old/template/extras/fmaddon-auth/app/auth/login/login-form.tsx
- packages/cli-old/template/extras/fmaddon-auth/app/auth/forgot-password/forgot-form.tsx
- packages/cli/template/fm-addon/ProofKitWV/info.json
- packages/registry/templates/table/basic/README.hbs
- packages/registry/templates/better-auth/auth.hbs
- packages/cli-old/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsx
- packages/cli-old/src/installers/nextAuth.ts
- packages/cli/template/extras/fmaddon-auth/app/auth/login/login-form.tsx
- packages/cli-old/template/fm-addon/ProofKitAuth/info.json
- packages/webviewer/package.json
- packages/typegen/src/constants.ts
- packages/cli-old/template/nextjs-shadcn/src/app/(main)/page.tsx
- packages/cli-old/template/nextjs-mantine/src/app/(main)/page.tsx
- packages/cli/src/installers/nextAuth.ts
- packages/typegen/stubs/proofkit-typegen.config.jsonc
- packages/cli/template/extras/emailProviders/none/email.tsx
- apps/docs/src/app/layout.tsx
- packages/cli/template/extras/fmaddon-auth/app/auth/signup/signup-form.tsx
- packages/cli/template/extras/emailTemplates/auth-code.tsx
- packages/fmodata/skills/typegen-fmodata/SKILL.md
- packages/cli-old/template/extras/fmaddon-auth/emails/auth-code.tsx
- packages/typegen/proofkit-typegen.fm-mcp.local.jsonc
- packages/cli/template/fm-addon/ProofKitAuth/info.json
- apps/docs/src/app/docs/(docs)/[[...slug]]/page.tsx
- apps/docs/src/app/robots.ts
- packages/cli-old/template/nextjs-shadcn/README.md
- packages/cli-old/template/vite-wv/proofkit-typegen.config.jsonc
- packages/typegen/src/server/api.ts
- packages/cli/src/utils/projectFiles.ts
- packages/cli-old/template/fm-addon/ProofKitWV/info.json
- packages/better-auth/package.json
- apps/docs/content/docs/fmdapi/quick-start.mdx
- packages/cli-old/template/extras/emailProviders/none/email.tsx
- packages/cli-old/template/extras/emailTemplates/auth-code.tsx
- packages/cli/template/nextjs-shadcn/src/app/(main)/page.tsx
- packages/cli-old/template/nextjs-mantine/README.md
- packages/typegen/src/server/app.ts
- packages/cli/template/extras/fmaddon-auth/emails/auth-code.tsx
- packages/cli-old/src/cli/add/data-source/deploy-demo-file.ts
- Auto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-03.md
- packages/typegen/proofkit-typegen.config.jsonc
- packages/cli-old/tsdown.config.ts
- apps/docs/content/docs/typegen/config.mdx
- packages/cli-old/src/installers/install-fm-addon.ts
- packages/cli/template/nextjs-shadcn/README.md
- packages/cli/template/extras/emailTemplates/generic.tsx
- Auto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-02.md
- packages/registry/templates/email/generic/generic.tsx
- README.md
- Auto Run Docs/Initiation/2026-03-19-ProofKit-Release-Readiness/RELEASE-READINESS-01.md
- apps/docs/content/docs/typegen/config-odata.mdx
- packages/cli-old/src/consts.ts
- packages/fmdapi/skills/typegen-fmdapi/SKILL.md
- packages/cli/src/installers/install-fm-addon.ts
- packages/cli/CLI_FLOW_AUDIT.md
- packages/cli/src/services/live.ts
- packages/cli/template/fm-addon/ProofKitAuth/ko.xml
- packages/typegen/tests/snapshots/zod-layout-client.snap.ts
- packages/cli-old/template/fm-addon/ProofKitAuth/es.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/nl.xml
- apps/docs/src/app/llms.txt/route.ts
- packages/cli/src/generators/fmdapi.ts
- packages/cli-old/template/extras/emailTemplates/generic.tsx
- packages/cli/template/fm-addon/ProofKitAuth/es.xml
- packages/cli/template/fm-addon/ProofKitAuth/sv.xml
- packages/cli/template/fm-addon/ProofKitAuth/de.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/sv.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/en.xml
- packages/cli/template/fm-addon/ProofKitAuth/fr.xml
- packages/cli/template/fm-addon/ProofKitAuth/it.xml
- packages/cli/template/fm-addon/ProofKitAuth/zh.xml
- packages/cli/template/fm-addon/ProofKitAuth/nl.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/zh.xml
- packages/cli/template/fm-addon/ProofKitAuth/ja.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/ja.xml
- packages/cli/template/fm-addon/ProofKitAuth/en.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/ko.xml
- packages/cli/template/fm-addon/ProofKitAuth/pt.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/fr.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/de.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/pt.xml
- packages/cli-old/template/fm-addon/ProofKitAuth/it.xml
🚧 Files skipped from review as they are similar to previous changes (4)
- apps/docs/src/lib/get-llm-text.ts
- .changeset/brown-owls-bake.md
- packages/cli/src/cli/add/data-source/deploy-demo-file.ts
- packages/cli-old/src/generators/fmdapi.ts
Comment on lines
+19
to
+22
| // Registry URL is injected at build time via tsdown define. | ||
| declare const __REGISTRY_URL__: string; | ||
| export const DEFAULT_REGISTRY_URL = | ||
| typeof __REGISTRY_URL__ !== "undefined" && __REGISTRY_URL__ ? __REGISTRY_URL__ : "https://proofkit.proof.sh"; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Locate tsdown config files =="
fd -i 'tsdown.config.ts' packages
echo
echo "== Find __REGISTRY_URL__ define/replace usage =="
rg -n --type=ts '__REGISTRY_URL__|define|replace\(' packages/cli packages/cli-old
echo
echo "== Confirm consts declaration/use =="
rg -n --type=ts 'declare const __REGISTRY_URL__|DEFAULT_REGISTRY_URL' packages/cli/src/consts.tsRepository: proofsh/proofkit
Length of output: 43940
🏁 Script executed:
cat -n packages/cli/tsdown.config.tsRepository: proofsh/proofkit
Length of output: 423
Add __REGISTRY_URL__ replacement to packages/cli/tsdown.config.ts build config.
The bundler does not currently replace __REGISTRY_URL__, so the override path at line 22 of packages/cli/src/consts.ts is inert. The check typeof __REGISTRY_URL__ !== "undefined" will always be false, and the constant will always fall back to the production domain. Restore the replace plugin configuration from packages/cli-old/tsdown.config.ts:
Expected configuration in `packages/cli/tsdown.config.ts`
replace({
__REGISTRY_URL__: JSON.stringify(isDev ? "http://localhost:3005" : "https://proofkit.proof.sh"),
})
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cli/src/consts.ts` around lines 19 - 22, The build never replaces
the compile-time constant __REGISTRY_URL__, so DEFAULT_REGISTRY_URL in
packages/cli/src/consts.ts always falls back to the production URL; fix
packages/cli/tsdown.config.ts by restoring the replace plugin configuration to
inject __REGISTRY_URL__ (use replace({ __REGISTRY_URL__: JSON.stringify(isDev ?
"http://localhost:3005" : "https://proofkit.proof.sh") })) so the runtime check
in DEFAULT_REGISTRY_URL works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps all
proofkit.devrefs toproofkit.proof.sh.Summary by CodeRabbit