Add troubleshooting note for ProofKit 2.04 add-on issue#265
Conversation
…to prod; fix logo dimensions - docs/ai/troubleshooting.mdx: new section for "access privileges damaged" warning from ProofKit 2.04 add-on install bug - screenshots/ai/filemaker-access-privileges-warning.png: screenshot for new section - instrumentation-client.ts / analytics.ts: gate PostHog init to production to suppress local-dev console errors - layout.config.tsx: correct logo intrinsic dimensions (96×150 → 2585×804)
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR restricts PostHog analytics to production environments, updates documentation with a FileMaker troubleshooting guide, and adjusts logo image dimensions in the docs app's navigation header. ChangesDocs App Configuration and Content Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/docs/src/app/layout.config.tsx (1)
17-19: ⚡ Quick winExtract repeated logo dimensions into named constants.
Line 17, Line 19, Line 24, and Line 26 duplicate intrinsic dimension literals (
804,2585). A shared constant pair keeps the light/dark variants in sync and makes intent clearer.♻️ Proposed refactor
+const LOGO_INTRINSIC_WIDTH = 2585; +const LOGO_INTRINSIC_HEIGHT = 804; + export const baseOptions = { nav: { title: ( <> <Image alt="ProofKit" className="block h-auto w-[96px] dark:hidden" - height={804} + height={LOGO_INTRINSIC_HEIGHT} src="/logo-horiz-light.svg" - width={2585} + width={LOGO_INTRINSIC_WIDTH} /> <Image alt="ProofKit" className="hidden h-auto w-[96px] dark:block" - height={804} + height={LOGO_INTRINSIC_HEIGHT} src="/logo-horiz-dark.svg" - width={2585} + width={LOGO_INTRINSIC_WIDTH} /> </> ),As per coding guidelines,
**/*.{js,jsx,ts,tsx}: Use meaningful variable names instead of magic numbers - extract constants with descriptive names.Also applies to: 24-26
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/docs/src/app/layout.config.tsx` around lines 17 - 19, Extract the repeated intrinsic dimensions into descriptive constants (e.g., LOGO_WIDTH and LOGO_HEIGHT) and replace the magic numbers used for both logo variants (the Image/Image-like props with src "/logo-horiz-light.svg" and "/logo-horiz-dark.svg") so both the light and dark logo usages reference the same constants; update any imports/exports or nearby scope to declare these constants near the top of the module (layout.config.tsx) so the height and width props use LOGO_HEIGHT and LOGO_WIDTH instead of 804 and 2585.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/docs/src/app/layout.config.tsx`:
- Around line 17-19: Extract the repeated intrinsic dimensions into descriptive
constants (e.g., LOGO_WIDTH and LOGO_HEIGHT) and replace the magic numbers used
for both logo variants (the Image/Image-like props with src
"/logo-horiz-light.svg" and "/logo-horiz-dark.svg") so both the light and dark
logo usages reference the same constants; update any imports/exports or nearby
scope to declare these constants near the top of the module (layout.config.tsx)
so the height and width props use LOGO_HEIGHT and LOGO_WIDTH instead of 804 and
2585.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f10f7f9c-b544-4ee5-84b4-35f2136b1e7c
⛔ Files ignored due to path filters (1)
apps/docs/public/screenshots/ai/filemaker-access-privileges-warning.pngis excluded by!**/*.png
📒 Files selected for processing (4)
apps/docs/content/docs/ai/troubleshooting.mdxapps/docs/src/app/layout.config.tsxapps/docs/src/instrumentation-client.tsapps/docs/src/lib/analytics.ts
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
1 participant
Summary
filemaker-access-privileges-warning.png) illustrating the dialoginstrumentation-client.tsandanalytics.ts)Test plan
/docs/ai/troubleshootingNODE_ENV !== 'production'guard)Summary by CodeRabbit
Documentation
Style
Chores