Issue #39: Add size prop to Crosshair component#45
Merged
imharrisonking merged 11 commits intoproductionfrom Mar 7, 2026
Merged
Issue #39: Add size prop to Crosshair component#45imharrisonking merged 11 commits intoproductionfrom
imharrisonking merged 11 commits intoproductionfrom
Conversation
- Add optional size prop with 'sm', 'md', 'lg' options - Default behavior unchanged (20x21px with -10.5px offset) - Use cva (class-variance-authority) for variant handling - Dynamically calculate viewBox and paths based on size config Sizes: - sm: 14x15px, offset -7.5px - md: 28x29px, offset -15px - lg: 36x37px, offset -19px
5 tasks
- Add pre-deploy SST unlock to clear stale locks from cancelled runs - Add post-deploy unlock with if: always() for cleanup on failure/cancel - Filter afk.sh issues to exclude those with open PRs waiting for review - Prevents CI lock errors when rapid commits trigger workflow cancellations
Contributor
Author
|
The deployment to the pr stage is failing: Run npx sst unlock --stage pr-45 These tokens should be available through the GitHub dev environment. How come this command fails yet the other npx sst commands work? Can you double check our .github/workflows file to make sure this is correctly setup for the new stage unlock step. |
Both sst unlock steps were missing CLOUDFLARE_API_TOKEN and CLOUDFLARE_DEFAULT_ACCOUNT_ID environment variables, causing the unlock command to fail with 'Cloudflare API not initialized' error. This fix ensures unlock can properly authenticate with Cloudflare to clear stale locks before/after deployment.
Resolved conflicts: - .github/workflows/pr-preview-deploy.yml: Keep both SST unlock step and database migrations - specs/progress.txt: Use production branch progress state
Quality Checks Failed
Please fix the issues above before merging. |
The lightningcss-darwin-arm64 package was incorrectly added as a top-level devDependency, causing npm ci to fail on Linux CI runners with EBADPLATFORM error. This package is a platform-specific native binary that should only exist as an optionalDependency of lightningcss itself. npm will automatically install the correct platform-specific version based on the current OS and architecture. Changes: - Removed lightningcss-darwin-arm64 from devDependencies - Regenerated package-lock.json to properly mark platform-specific packages as optional This ensures the build works on: - macOS ARM64 (Apple Silicon) - macOS x64 (Intel Macs) - Linux x64 (CI runners) - Any other supported platforms
The build was failing with: "managedNonce" is not exported by "@noble/ciphers/esm/utils.js" Root cause: Two versions of @noble/ciphers were installed: - v1.3.0 (from eciesjs) - does NOT export managedNonce - v2.1.1 (from better-auth) - DOES export managedNonce The bundler was resolving to v1.3.0 at the root level, causing the import error when building. Fix: Added @noble/ciphers to overrides in package.json to force v2.1.1 across all packages, ensuring the managedNonce export is always available.
After merging with production, several type mismatches appeared: 1. OTPType - better-auth now supports 'change-email' OTP type - Updated OTPType in packages/backend/src/auth/email.tsx - Updated VerifyEmailProps in notifications/emails/VerifyEmail.tsx - Updated FormattedType class in notifications/utils/text.tsx - Added handling for change-email in sendVerificationOTP 2. Button component - restore isLoading, icon, isError props - Production's Button didn't have these props that were on the feature branch - Restored isLoading and icon from original feature branch - Added isError prop to support new onboarding component from production - All components using these props now type-check correctly
Preview Environment
Quality checks passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements changes for issue #39: Add size prop to Crosshair component
Branch: 39-add-size-prop-to-crosshair-component
Changes Made
sizeprop toCrosshaircomponent with 'sm', 'md', 'lg' optionscva(class-variance-authority) for variant handling, consistent with other UI componentsSize configurations:
smmdlgTesting
Checklist
Related Issue
Closes #39