UI Tweaks #8
UI Tweaks #8
Conversation
src/android/InAppBrowser.java
Outdated
| footerBorderBackground.setStroke(1, android.graphics.Color.parseColor("#E9E6E1")); | ||
| int footerBorderBackgroundColor = getShowPageTitleHeader() ? toolbarColor : _footerColor; | ||
| footerBorderBackground.setColor(footerBorderBackgroundColor); | ||
| footerBorderBackground.setStroke(1, manipulateColor(footerBorderBackgroundColor, 0.8f)); |
There was a problem hiding this comment.
what is the point of doing the math and rounding found in manipulateColor vs setting to footerBorderBackgroundColor here?
There was a problem hiding this comment.
We need footerBorderBackgroundColor for the footer background and the color from manipulate is used for the border color. I made a separate helper function so it doesn't get cluttered here and so we can use it for the header border color.
| blue:MAX(b - 0.2, 0.0) | ||
| alpha:a]; | ||
| return nil; | ||
| } |
There was a problem hiding this comment.
is this doing the same thing as manipulate function in android?
There was a problem hiding this comment.
Similar. This one is returning a darker shade and manipulate returns a darker or lighter shade depending on factor. Maybe I should make them do the same thing so it's more consistent 🤔
There was a problem hiding this comment.
I think it would be useful to be as consistent as possible between the two.
I would advocate for removing manipulate if we can get away with just adding the darker shade. If we cannot just darken, manipulate is probably fine
There was a problem hiding this comment.
I changed manipulateColor to darkerColorForColor for Android.
paetling
left a comment
paetling
left a comment
There was a problem hiding this comment.
I had a few questions to flesh out my understanding, but generally looks good.
👻 🐮
* Updated iOS lock icon to use SF symbol * Updated iOS nav button icons to use SF symbols * Updated iOS navBar header background color to be customizable * Updated iOS page title header text color to be customizable * Updated iOS toolbar border color * Updated android with toolbartextcolor and automatic tooldbar border color * Updated README and default android toolbartextcolor * Updated android color helper function
This reverts commit e81d69f.
Various UI tweaks and bug fixes from IAB testing.
Changes
toolbarcolor. It defaults to system default (depends if the device is in dark mode or not).toolbartextcolorcontrols text color in toolbar. Currently that's only the page title text and icon.Screenshots
iOS default colors for toolbar, text, and buttons
iOS default colors in for toolbar, te
xt, and buttons dark mode
Android default colors
