Remove support for SFMT #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once upon a time, PropEr was enhanced with a configure option to employ sfmt-erlang as an alternative to the random generator module, which was (back then) quite slow(er). Since then, Erlang/OTP has got support for RNG in the form of the new `rand` module, which incorporates most (all?) advantages that sfmt provides. To simplify the code, support for sfmt-erlang is thereby discontinued. It's not clear how used this configure option was in practice, anyway.
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 82.68% 82.43% -0.26%
==========================================
Files 13 13
Lines 3183 3183
==========================================
- Hits 2632 2624 -8
- Misses 551 559 +8
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, PropEr was enhanced with a configure option to employ
sfmt-erlang as an alternative to the random generator module, which was
(back then) quite slow(er). Since then, Erlang/OTP has got support for
RNG in the form of the new
randmodule, which incorporates most (all?)advantages that sfmt provides.
To simplify the code, support for sfmt-erlang is thereby discontinued.
It's not clear how used this configure option was in practice, anyway.