Improve handling of diverse coordinate datatypes#121
Merged
Conversation
lukelbd
changed the title
lukelbd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #103. This bug was caused by my
standardize_1dandstandardize_2dfunctions, which automatically appliedIndexFormatterwhen they detected coordinate arrays of the'object'datatype (while this usually implies strings, it turns out cftime arrays are also of'object'datatype).I am now more careful about how the standardize functions handle coordinates. The
IndexFormatteris applied only for string arrays, and the centers-to-edges and edges-to-centers functions only work with numeric (non-datetime, non-string) coordinates.