Permit setting 'style' to default, and add 'bbox' as 'border' alternative for inner a-b-c labels and titles#240
Merged
lukelbd merged 5 commits intoproplot-dev:masterfrom Jun 30, 2021
Conversation
Collaborator
|
Hi @pratiman-91, thanks for the PR! That bugfix is easy and I like the idea of "bounding boxes" for titles and a-b-c labels. When you get the chance can you fix the PEP8 errors? Also you might consider installing |
Collaborator
|
(Fixes #234) |
Collaborator
|
Apparently I'm allowed to edit your PR myself (never did that before!). This was close to being ready anyway so I decided to fix the issues. Thanks again, merging now |
lukelbd
added a commit
that referenced
this pull request
Jul 1, 2021
Collaborator
|
I made some improvements to this feature on master (4288a73):
Here's a nice example with these new features: import proplot as plot
fig, ax = plot.subplots(ncols=2)
print(plot.rc.abcborder) # prints True
ax.contourf(np.random.rand(10, 10))
ax.format(abc=True, abcloc='ul', abcstyle='A.', abcbbox=True) # temporarily sets border to False |
Contributor
Author
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is my first contribution. Let me know if there is any problem with the issue or failing any tests.