Skip to content

feat/dynamic server secrets#2437

Merged
forgetso merged 2 commits intomainfrom
feat/dynamic-server-secrets
Mar 4, 2026
Merged

feat/dynamic server secrets#2437
forgetso merged 2 commits intomainfrom
feat/dynamic-server-secrets

Conversation

@forgetso
Copy link
Copy Markdown
Member

@forgetso forgetso commented Mar 4, 2026

  • docs(changeset): Dynamic server secrets for client example server
  • Generate server secret dynamically

Copilot AI review requested due to automatic review settings March 4, 2026 15:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the client example server to derive the correct server secret dynamically (based on captcha type) when verifying Procaptcha tokens, and includes updated provider detector decode artifacts plus a changeset.

Changes:

  • Add getPairAndSecretForSiteKey() to derive the correct KeyringPair/secret suffix for a given siteKey, and use it in both signup and login verification flows.
  • Replace several console.log debug statements with structured logging via getLogger.
  • Update provider-side detection decode bundles (decodePayload.js, decodeBehavior.js) and add a changeset for patch releases.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/provider/src/tasks/detection/decodePayload.js Updates the bundled/minified payload decode implementation used by the provider detection task.
packages/provider/src/tasks/detection/decodeBehavior.js Updates the bundled/minified behavior decode implementation used by the provider detection task.
demos/client-example-server/src/controllers/auth.ts Derives the correct secret per siteKey and switches much of the debug output to structured logging.
demos/client-example-server/src/app.ts Switches verify-endpoint startup logging to use the configured logger.
.changeset/beige-snails-scream.md Declares patch releases for the affected packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@forgetso forgetso merged commit 759d4e6 into main Mar 4, 2026
13 checks passed
@forgetso forgetso deleted the feat/dynamic-server-secrets branch March 4, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants