fix/invalidate domains with incorrect dots#2460
Merged
Conversation
Member
forgetso
commented
Mar 23, 2026
forgetso
commented
- Invalidate domains with incorrect dots
- docs(changeset): Invalidate domains with incorrect dots
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens domain syntax validation in @prosopo/util to reject domains with “incorrect dots” (empty labels), aligning domain handling with stricter hostname rules and preventing malformed domains from being treated as valid.
Changes:
- Add an early rejection in
validateDomain()for consecutive dots (..), leading dot, and trailing dot. - Add a changeset marking
@prosopo/utilfor a patch release with this validation change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/util/src/url.ts | Adds explicit invalidation for domains with empty-label dot patterns before regex/URL parsing. |
| .changeset/cozy-seas-enjoy.md | Declares a patch release entry documenting the domain validation change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.