Adding script to test performance of local dbpa agent#214
Merged
avalerio-tkd merged 5 commits intomainfrom Feb 4, 2026
Merged
Conversation
argmarco-tkd
reviewed
Feb 3, 2026
src/scripts/performance_test.cpp
Outdated
| ("h,help", "Display this help message"); | ||
|
|
||
| try { | ||
| auto result = options.parse(argc, argv); |
Collaborator
There was a problem hiding this comment.
confusing variable name :)
Collaborator
Author
There was a problem hiding this comment.
Updated. Thanks :)
src/scripts/performance_test.cpp
Outdated
Comment on lines
+137
to
+138
| int32_t max_definition_level = 1, | ||
| int32_t max_repetition_level = 0, |
Collaborator
There was a problem hiding this comment.
not sure if it matters, but defaults here are different than for V1
Collaborator
Author
There was a problem hiding this comment.
Thanks. Doesn't matter, updated for consistency. This was inherited from the previous incarnation of the test.
| std::optional<int> datatype_length, | ||
| std::optional<std::map<std::string, std::string>> column_encryption_metadata = std::nullopt) { | ||
| std::string app_context = R"({"user_id": "demo_user_123"})"; | ||
| auto agent = std::make_unique<LocalDataBatchProtectionAgent>(); |
Collaborator
There was a problem hiding this comment.
love this. we're skipping the DLL loading. nice.
…neration consistently.
Collaborator
Author
|
@argmarco-tkd could you PTAL? |
…eneration params.
Collaborator
Author
|
Made an inconsequential update to dbpa_remote_testapp.cpp to make data_page creation params consistent. Gonna merge as-is, not worth doing another review just for that. But if you want to discuss that, sure let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.