Fix: post-merge verification failure for 'Docker + homelab-iac wiring'

[mabry1985]

Summary

Post-Merge Verification Failure

Feature Docker + homelab-iac wiring (feature-1775968134991-md0brvyeg) was merged but post-merge verification failed. The code is live — this bug fix should address the regression.

Failed Commands

npm run typecheck

Command failed: npm run typecheck
npm error code ENOENT
npm error syscall open
npm error path /home/josh/dev/labs/ava/package.json
npm error errno -2
npm error enoent Could not read package.json: Error: ENOENT: no such file or dire...

---
*Recovered automatically by Automaker post-agent hook*

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Chores**
  * Updated internal build configuration and metadata to support development tooling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

[coderabbitai]

Walkthrough

Updated .automaker-lock metadata with a new feature identifier and timestamp. Added a new package.json file containing a typecheck script that validates Python syntax across app and voice module files.

Changes

Cohort / File(s)	Summary
Metadata Update .automaker-lock	Updated featureId and startedAt timestamp values; JSON structure and pid remain unchanged.
Build Configuration package.json	New file added with typecheck npm script that runs Python bytecode compilation checks on app entry point, voice modules, and skills modules, then confirms completion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing a post-merge verification failure caused by a missing package.json file, which is directly addressed by the PR's addition of package.json with the typecheck script.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/fix-post-merge-verification-failure-for-docker-lj36sfp

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix/fix-post-merge-verification-failure-for-docker-lj36sfp

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 1-9: The package.json currently defines a scripts.typecheck entry
that runs python3 -m py_compile on several Python modules (scripts.typecheck)
which is unconventional for a Python project; replace this with Python-native
tooling by creating a pyproject.toml (or tox.ini) to declare
linters/type-checkers (e.g., ruff/mypy/flake8) and add a Makefile or tox target
(e.g., make typecheck or tox -e typecheck) that runs the equivalent checks for
the same files (app.py, voices.py, skills/*.py, voice/*.py), and add a
.pre-commit-config.yaml to run those checks locally; if CI currently relies on
npm, keep a minimal package.json scripts.typecheck that forwards to the new
target (e.g., invoke make typecheck or tox -e typecheck) so CI compatibility is
preserved while migrating to Python-native tooling.
- Line 7: The typecheck npm script currently hardcodes every Python file (the
"typecheck" entry referencing app.py, voices.py, and many files under skills/
and voice/), which is brittle; update the "typecheck" script to use Python's
compileall to recursively check directories (e.g., run python3 -m compileall
with the -q/silent flag against app.py, voices.py and the skills/ and voice/
directories) so new .py files under skills/ and voice/ are automatically
syntax-checked; replace the long hardcoded list in the "typecheck" package.json
script with this compileall-based command and keep the final echo 'Python syntax
check passed' behavior on success.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 62d9694a-98f5-4c14-b3ba-b149b2e79019

📥 Commits

Reviewing files that changed from the base of the PR and between b6d6fed and fb081f3.

📒 Files selected for processing (2)

• .automaker-lock
• package.json

[coderabbitai]

🧹 Nitpick | 🔵 Trivial

Consider Python-native tooling for type/syntax checking.

While using package.json solves the immediate post-merge verification failure, it's unconventional for a Python project. Python projects typically use:

• pyproject.toml with tool configurations
• Makefile for common commands
• tox.ini for testing and checks
• Pre-commit hooks via .pre-commit-config.yaml

If the project needs to maintain npm compatibility (e.g., for CI/CD pipelines expecting npm run commands), the current approach is acceptable. Otherwise, consider migrating to Python-native tooling for better ecosystem alignment.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 1 - 9, The package.json currently defines a
scripts.typecheck entry that runs python3 -m py_compile on several Python
modules (scripts.typecheck) which is unconventional for a Python project;
replace this with Python-native tooling by creating a pyproject.toml (or
tox.ini) to declare linters/type-checkers (e.g., ruff/mypy/flake8) and add a
Makefile or tox target (e.g., make typecheck or tox -e typecheck) that runs the
equivalent checks for the same files (app.py, voices.py, skills/*.py,
voice/*.py), and add a .pre-commit-config.yaml to run those checks locally; if
CI currently relies on npm, keep a minimal package.json scripts.typecheck that
forwards to the new target (e.g., invoke make typecheck or tox -e typecheck) so
CI compatibility is preserved while migrating to Python-native tooling.

[coderabbitai]

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify that all Python files listed in the typecheck script exist

files=(
  "app.py"
  "voices.py"
  "skills/__init__.py"
  "skills/loader.py"
  "skills/models.py"
  "voice/__init__.py"
  "voice/agent.py"
  "voice/chunker.py"
  "voice/llm.py"
  "voice/react_agent.py"
  "voice/stt.py"
  "voice/tts.py"
)

missing=()
for file in "${files[@]}"; do
  if [[ ! -f "$file" ]]; then
    missing+=("$file")
  fi
done

if [[ ${`#missing`[@]} -eq 0 ]]; then
  echo "✓ All listed Python files exist"
else
  echo "✗ Missing files:"
  printf '  %s\n' "${missing[@]}"
  exit 1
fi

Repository: protoLabsAI/ava

Length of output: 90

---

Refactor to avoid hardcoded file list.

The typecheck script hardcodes all Python file paths, which creates a maintenance burden. When new Python files are added to the skills/ or voice/ directories, developers must remember to update this script, or those files won't be syntax-checked.

Consider using Python's compileall module to recursively check directories:

♻️ Proposed refactor using Python's compileall module

-    "typecheck": "python3 -m py_compile app.py voices.py skills/__init__.py skills/loader.py skills/models.py voice/__init__.py voice/agent.py voice/chunker.py voice/llm.py voice/react_agent.py voice/stt.py voice/tts.py && echo 'Python syntax check passed'"
+    "typecheck": "python3 -m compileall -q app.py voices.py skills/ voice/ && echo 'Python syntax check passed'"

The -q flag suppresses output for successful files, only showing errors. This approach automatically checks all .py files in the skills/ and voice/ directories, eliminating the need to manually update the list when new files are added.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"typecheck": "python3 -m py_compile app.py voices.py skills/__init__.py skills/loader.py skills/models.py voice/__init__.py voice/agent.py voice/chunker.py voice/llm.py voice/react_agent.py voice/stt.py voice/tts.py && echo 'Python syntax check passed'"
	"typecheck": "python3 -m compileall -q app.py voices.py skills/ voice/ && echo 'Python syntax check passed'"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 7, The typecheck npm script currently hardcodes every
Python file (the "typecheck" entry referencing app.py, voices.py, and many files
under skills/ and voice/), which is brittle; update the "typecheck" script to
use Python's compileall to recursively check directories (e.g., run python3 -m
compileall with the -q/silent flag against app.py, voices.py and the skills/ and
voice/ directories) so new .py files under skills/ and voice/ are automatically
syntax-checked; replace the long hardcoded list in the "typecheck" package.json
script with this compileall-based command and keep the final echo 'Python syntax
check passed' behavior on success.

[mabry1985]

Closing — merge conflicts have diverged from main. Per rebase policy, this will be re-cut from current main if the work is still needed.