feat(loop): reconcile in_review PRs to their real state (merged + closed)

[mabry1985]

What

The first P2 reconciliation port. The merge poll only handled MERGED, so a feature whose PR was closed without merging sat in_review forever — the same stuck-forever class the poll was meant to kill (the merge webhook fires on merge, never on a manual close).

The poll is now a full PR reconcile:

• worktree.pr_state(pr_url) → MERGED / CLOSED / OPEN ("" on a gh failure → next poll retries).
• _reconcile_prs drives the terminal edges: MERGED → done (+reap; the existing idempotent edge), CLOSED-unmerged → Blocked for triage (+reap; the work was rejected — don't silently re-dispatch and fight whoever closed it), OPEN → leave in review.

Renamed _poll_merges → _reconcile_prs and _maybe_poll_merges → _maybe_reconcile; pr_is_merged → pr_state. Config is unchanged (merge_poll / merge_poll_interval_s).

Tests

116 total, all green: reconcile drives merged→done + closed→blocked + leaves open (reaps both terminal states); pr_state returns the state / "" on gh failure; reconcile rate-limit + disabled. ruff clean.

Remaining ports

• P2: file-contention auto-deps at creation · capacity/forecast + cost surface · sitrep tool
• P3: HITL escalation rung (host bus) · downstreamImpact tie-break

🤖 Generated with Claude Code

[protoquinn]

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

[protoquinn]

QA Audit — PR #13 | feat(loop): reconcile in_review PRs to their real state (merged + closed)

VERDICT: WARN

---

CI Status

• test: in_progress ⏳

Diff Review

• Renames _poll_merges→_reconcile_prs, pr_is_merged→pr_state — clean rename, docs + config comments updated consistently across all 4 files.
• New CLOSED branch calls store.flag_blocked(fid, reason) + reaps — correctly prevents silent re-dispatch of rejected work.
• OPEN branch is a deliberate no-op (leave in_review) — correct.
• Error handling widened to catch the whole per-feature block — safer than before (catches record_merge/flag_blocked/reap failures too).
• Test test_reconcile_drives_merged_to_done_and_closed_to_blocked covers all three states; reaps verified for both terminal states.

Observations

• GAP: worktree.pr_state is called but not visible in this diff (diff truncated at 200/290 lines — remaining 90 may contain worktree.py changes). Cannot verify the function exists on this branch.
• GAP: store.flag_blocked(fid, reason) is called on the real store — cannot verify this method exists on the production store class (test mock defines it, but that doesn't prove the real store has it).
• LOW: clawpatch structural review unavailable for this repo (not in project registry) — proceeding with diff-only review.
• LOW: CI still in_progress — formal PASS/FAIL deferred to re-dispatch once checks settle.

— Quinn, QA Engineer

[protoquinn]

Submitted COMMENTED review on #13.